Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: tools/perf/metrics/timeline.py

Issue 15673005: cc: Add compositor name for easier GPU debugging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/timeline.py
diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py
index 5714b4a3c3671a54e7b4f9cc88f3326c8324c92b..682be38df6dbe21bd2add1c4d81bab3469ba08c9 100644
--- a/tools/perf/metrics/timeline.py
+++ b/tools/perf/metrics/timeline.py
@@ -97,8 +97,8 @@ class LoadTimesTimelineMetric(TimelineMetric):
# Since we can't isolate renderer threads in single-process mode, we
# always sum renderer-process threads' times. We also sum all io-threads
# for simplicity.
+MatchBySubString = ["IOThread", "CompositorRasterWorker"]
TimelineThreadCategories = {
- # These are matched exactly
"Chrome_InProcGpuThread": "GPU",
"CrGPUMain" : "GPU",
"AsyncTransferThread" : "GPU_transfer",
@@ -106,7 +106,6 @@ TimelineThreadCategories = {
"Browser Compositor" : "browser_compositor",
"CrRendererMain" : "renderer_main",
"Compositor" : "renderer_compositor",
- # These are matched by substring
"IOThread" : "IO",
"CompositorRasterWorker": "raster"
}
@@ -136,7 +135,7 @@ class ThreadTimesTimelineMetric(TimelineMetric):
# Check substrings first, followed by exact matches
thread_category = None
for substring, category in TimelineThreadCategories.iteritems():
- if substring in thread.name:
+ if substring in thread.name and substring in MatchBySubString:
thread_category = category
if thread.name in TimelineThreadCategories:
thread_category = TimelineThreadCategories[thread.name]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698