Issue 15673005: cc: Add compositor name for easier GPU debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15673005: cc: Add compositor name for easier GPU debugging. (Closed)

Created:
7 years, 6 months ago by epenner

Modified:
6 years, 11 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

cc: Add compositor name for easier GPU debugging. Allows for custom name to be passed to GPU process, where it can be used for debugging. BUG=181711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202824

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use BrowserCompositor. #

Patch Set 3 : #

Patch Set 4 : Revert. #

Patch Set 5 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tools/perf/metrics/timeline.py	View	1 2 3 4	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aelias_OOO_until_Jul13

lgtm https://codereview.chromium.org/15673005/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/15673005/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode204 content/browser/renderer_host/compositor_impl_android.cc:204: settings.compositor_name = "AndroidCompositor"; "BrowserCompositor" would be clearer I ...

7 years, 6 months ago (2013-05-29 05:41:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/15673005/6001

7 years, 6 months ago (2013-05-29 06:15:29 UTC) #3

Message was sent while issue was closed.

Change committed as 202824

Expand Messages | Collapse Messages