Issue 15670012: Add 76 column reference in git cl upload message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15670012: Add 76 column reference in git cl upload message (Closed)

Created:
7 years, 6 months ago by alancutter (OOO until 2018)

Modified:
7 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Add 76 column reference in git cl upload message Adds an extra line to the default text description to help judge whether the 76 character recommended limit is being passed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=203314

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	git_cl.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tests/git_cl_test.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/15670012/1

7 years, 6 months ago (2013-05-31 02:21:01 UTC) #3

Noel Gordon

7 years, 6 months ago (2013-05-31 05:50:22 UTC) #5

Message was sent while issue was closed.

Nice. Could we make it 72 please? (consider reverts :).

Expand Messages | Collapse Messages