Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 15670003: Fix edge case in stack trace formatting. (Closed)

Created:
7 years, 7 months ago by Yang
Modified:
7 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Fix edge case in stack trace formatting. Bug description: in strict mode, null as receiver is not implicitly converted to the global object, so that when formatting the stack trace, the receiver of the stack frame is null. The IS_OBJECT check returns true for null, but %GetDataProperty expected a JSObject, which results in a failed RUNTIME_ASSERT. R=mvstanton@chromium.org BUG=237617 Committed: https://code.google.com/p/v8/source/detail?r=14797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/messages.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-237617.js View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 7 months ago (2013-05-24 10:46:37 UTC) #1
mvstanton
Looks good, lgtm.
7 years, 7 months ago (2013-05-24 10:57:27 UTC) #2
Yang
7 years, 7 months ago (2013-05-24 11:33:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698