Issue 15667004: Add resize support for Views new style dialogs.

Issue 15667004: Add resize support for Views new style dialogs. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
msw, sky

CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add resize support for Views new style dialogs. Implements proper bubble non-client frame view hit testing. Use NonClientFrameView::GetHTComponentForFrame hit testing. (this is similar to the implementation of CustomFrameView) Remove the |can_drag_| flag, use WidgetDelegate::CanResize(). BUG=166075 TEST=New dialog style windows resize, drag, and generally allow mouse interaction as expected. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202000

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove incorrect DialogDelegate::CanResize overrride. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	ui/views/bubble/bubble_frame_view.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view.cc	View		3 chunks	+11 lines, -4 lines	0 comments	Download
M	ui/views/window/dialog_delegate.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

https://codereview.chromium.org/15667004/diff/1/ui/views/window/dialog_delegate.cc File ui/views/window/dialog_delegate.cc (right): https://codereview.chromium.org/15667004/diff/1/ui/views/window/dialog_delegate.cc#newcode154 ui/views/window/dialog_delegate.cc:154: return true; Won't this make all dialogs resizable?

7 years, 7 months ago (2013-05-23 14:44:10 UTC) #2

msw

Comment addressed; please take another look, thanks! https://codereview.chromium.org/15667004/diff/1/ui/views/window/dialog_delegate.cc File ui/views/window/dialog_delegate.cc (right): https://codereview.chromium.org/15667004/diff/1/ui/views/window/dialog_delegate.cc#newcode154 ui/views/window/dialog_delegate.cc:154: return true; ...

7 years, 7 months ago (2013-05-23 19:30:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15667004/10001

7 years, 7 months ago (2013-05-23 21:23:45 UTC) #5

Message was sent while issue was closed.

Change committed as 202000

Expand Messages | Collapse Messages