Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6011)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 15666005: Make WebRequestAction::GetName a pure virtual function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
index e7fbecf0e35160cdbcb07d3697e9b9feb9313659..79a46bffec78d4598e22dded160250ce2ba86638 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
@@ -542,12 +542,34 @@ TEST(WebRequestActionTest, GetName) {
" \"lowerPriorityThan\": 123,"
" \"hasTag\": \"some_tag\""
"}]";
+ const char* kExpectedNames[] = {
+ "declarativeWebRequest.RedirectRequest",
+ "declarativeWebRequest.RedirectByRegEx",
+ "declarativeWebRequest.SetRequestHeader",
+ "declarativeWebRequest.RemoveRequestHeader",
+ "declarativeWebRequest.AddResponseHeader",
+ "declarativeWebRequest.RemoveResponseHeader",
+ "declarativeWebRequest.SendMessageToExtension",
+ "declarativeWebRequest.AddRequestCookie",
+ "declarativeWebRequest.AddResponseCookie",
+ "declarativeWebRequest.EditRequestCookie",
+ "declarativeWebRequest.EditResponseCookie",
+ "declarativeWebRequest.RemoveRequestCookie",
+ "declarativeWebRequest.RemoveResponseCookie",
+ "declarativeWebRequest.CancelRequest",
+ "declarativeWebRequest.RedirectToTransparentImage",
+ "declarativeWebRequest.RedirectToEmptyDocument",
+ "declarativeWebRequest.IgnoreRules",
+ };
scoped_ptr<WebRequestActionSet> action_set(CreateSetOfActions(kActions));
+ ASSERT_EQ(arraysize(kExpectedNames), action_set->actions().size());
+ size_t index = 0;
for (WebRequestActionSet::Actions::const_iterator it =
action_set->actions().begin();
it != action_set->actions().end();
++it) {
- EXPECT_THAT((*it)->GetName(), HasSubstr("declarativeWebRequest."));
+ EXPECT_EQ(kExpectedNames[index], (*it)->GetName());
+ ++index;
}
}
« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698