Issue 15666005: Make WebRequestAction::GetName a pure virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15666005: Make WebRequestAction::GetName a pure virtual function (Closed)

Created:
7 years, 7 months ago by battre

Modified:
7 years, 7 months ago

Reviewers:
vabr (Chromium), battre

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make WebRequestAction::GetName a pure virtual function This CL makes WebRequestAction::GetName. This is the only way to guarantee that it returns the instanceType of the actual action as specified in the JSON dictionary. BUG=112155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201999

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -56 lines)			Patch
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h	View	15 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc	View	16 chunks	+71 lines, -52 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc	View	1 chunk	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/15666005/1

7 years, 7 months ago (2013-05-23 16:16:12 UTC) #3

Message was sent while issue was closed.

Change committed as 201999

Expand Messages | Collapse Messages