V4L2(S)VDA: Check if device handles profile for supported fourccs on init.

V4L2(S)VDA: Check if device handles profile for supported fourccs on init.

A media::VideoCodecProfile can be supported by a device via different V4L2
fourccs. For example, H264 profiles may be supported via V4L2_PIX_FMT_H264
or V4L2_PIX_FMT_H264_SLICE. A single VDA type may only support a subset of
these fourccs however.

When querying for supported profiles, we return a sum of all supported
profiles for all VDAs on the system, and then rely on VDA selection code to
instantiate each VDA one by one and find the first one that does not fail
for the requested profile. In V4L2 VDAs, this effectively happens when
querying supported resolutions, resulting in confusing error messages in
the logs about the VDA not being able to query supported resolutions.

To prevent this, check if the requested profile is handled in the device
via fourccs that the VDA supports earlier, on VDA::Initialize().

BUG=None
TEST=vdatest, crosvideo.appspot

Committed: https://crrev.com/ce4fe47570a6fe94438791c8b16de92283b6e6f6
Cr-Commit-Position: refs/heads/master@{#368835}

[Pawel Osciak, 2016-01-06 04:02:20]

posciak@chromium.org changed reviewers:
+ henryhsu@chromium.org, wuchengli@chromium.org

[Pawel Osciak, 2016-01-06 04:02:20]

ptal

[wuchengli, 2016-01-12 07:35:13]

lgtm

https://chromiumcodereview.appspot.com/1566533003/diff/1/content/common/gpu/m...
File content/common/gpu/media/v4l2_device.h (right):

https://chromiumcodereview.appspot.com/1566533003/diff/1/content/common/gpu/m...
content/common/gpu/media/v4l2_device.h:127: // fourcss from the given array of
|pixelformats| of size |num_formats|.
s/fourcss/fourccs/

[Pawel Osciak, 2016-01-12 08:03:29]

https://chromiumcodereview.appspot.com/1566533003/diff/1/content/common/gpu/m...
File content/common/gpu/media/v4l2_device.h (right):

https://chromiumcodereview.appspot.com/1566533003/diff/1/content/common/gpu/m...
content/common/gpu/media/v4l2_device.h:127: // fourcss from the given array of
|pixelformats| of size |num_formats|.
On 2016/01/12 07:35:13, wuchengli wrote:
> s/fourcss/fourccs/

Oh nice catch, thanks.

[Pawel Osciak, 2016-01-12 08:03:33]

The CQ bit was checked by posciak@chromium.org

[Pawel Osciak, 2016-01-12 08:03:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
wuchengli@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1566533003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-12 08:04:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1566533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1566533003/20001

[commit-bot: I haz the power, 2016-01-12 08:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 08:14:54]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Pawel Osciak, 2016-01-12 08:43:46]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2016-01-12 08:44:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1566533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1566533003/20001

[commit-bot: I haz the power, 2016-01-12 09:03:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 09:04:43]

Description was changed from

==========
V4L2(S)VDA: Check if device handles profile for supported fourccs on init.

A media::VideoCodecProfile can be supported by a device via different V4L2
fourccs. For example, H264 profiles may be supported via V4L2_PIX_FMT_H264
or V4L2_PIX_FMT_H264_SLICE. A single VDA type may only support a subset of
these fourccs however.

When querying for supported profiles, we return a sum of all supported
profiles for all VDAs on the system, and then rely on VDA selection code to
instantiate each VDA one by one and find the first one that does not fail
for the requested profile. In V4L2 VDAs, this effectively happens when
querying supported resolutions, resulting in confusing error messages in
the logs about the VDA not being able to query supported resolutions.

To prevent this, check if the requested profile is handled in the device
via fourccs that the VDA supports earlier, on VDA::Initialize().

BUG=None
TEST=vdatest, crosvideo.appspot
==========

to

==========
V4L2(S)VDA: Check if device handles profile for supported fourccs on init.

A media::VideoCodecProfile can be supported by a device via different V4L2
fourccs. For example, H264 profiles may be supported via V4L2_PIX_FMT_H264
or V4L2_PIX_FMT_H264_SLICE. A single VDA type may only support a subset of
these fourccs however.

When querying for supported profiles, we return a sum of all supported
profiles for all VDAs on the system, and then rely on VDA selection code to
instantiate each VDA one by one and find the first one that does not fail
for the requested profile. In V4L2 VDAs, this effectively happens when
querying supported resolutions, resulting in confusing error messages in
the logs about the VDA not being able to query supported resolutions.

To prevent this, check if the requested profile is handled in the device
via fourccs that the VDA supports earlier, on VDA::Initialize().

BUG=None
TEST=vdatest, crosvideo.appspot

Committed: https://crrev.com/ce4fe47570a6fe94438791c8b16de92283b6e6f6
Cr-Commit-Position: refs/heads/master@{#368835}
==========

[commit-bot: I haz the power, 2016-01-12 09:04:44]

Patchset 2 (id:??) landed as
https://crrev.com/ce4fe47570a6fe94438791c8b16de92283b6e6f6
Cr-Commit-Position: refs/heads/master@{#368835}