Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: tools/perf/perf_tools/skpicture_printer.py

Issue 15665003: Modifications to skpicture_printer (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/perf_tools/skpicture_printer.py
===================================================================
--- tools/perf/perf_tools/skpicture_printer.py (revision 199247)
+++ tools/perf/perf_tools/skpicture_printer.py (working copy)
@@ -9,16 +9,22 @@
class SkPicturePrinter(page_measurement.PageMeasurement):
def AddCommandLineOptions(self, parser):
- parser.add_option('-o', '--outdir', help='Output directory')
+ parser.add_option('-s', '--skp-outdir',
+ help='Output directory for the SKP files')
def CustomizeBrowserOptions(self, options):
options.extra_browser_args.extend(['--enable-gpu-benchmarking',
- '--no-sandbox'])
+ '--no-sandbox',
+ '--enable-deferred-image-decoding',
+ '--force-compositing-mode'])
def MeasurePage(self, page, tab, results):
- if self.options.outdir is not None:
- outpath = os.path.join(self.options.outdir, page.url_as_file_safe_name)
- outpath = os.path.abspath(outpath)
+ skp_outdir = self.options.skp_outdir
+ if not skp_outdir:
+ raise Exception('Please specify --skp-outdir')
+ outpath = os.path.abspath(
+ os.path.join(skp_outdir,
+ page.url_as_file_safe_name))
# Replace win32 path separator char '\' with '\\'.
js = _JS.format(outpath.replace('\\', '\\\\'))
tab.EvaluateJavaScript(js)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698