Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 15664005: Update the gap resolver to support Smi constants. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Update the gap resolver to support Smi constants. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14850

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-05-28 12:16:25 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-05-28 12:36:41 UTC) #2
Toon Verwaest
7 years, 6 months ago (2013-05-28 12:37:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698