Source/web/LinkHighlight.cpp - Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/LinkHighlight.cpp

Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/LinkHighlight.cpp

diff --git a/Source/web/LinkHighlight.cpp b/Source/web/LinkHighlight.cpp

index 9255fb447477b9d7b62b8e40b43347f5c55dc6b6..fbfb13f39aac3adf9474534c654bf27ddb54be68 100644

--- a/Source/web/LinkHighlight.cpp

+++ b/Source/web/LinkHighlight.cpp

@@ -142,7 +142,7 @@ RenderLayer* LinkHighlight::computeEnclosingCompositingLayer()

clearGraphicsLayerLinkHighlightPointer();

m_currentGraphicsLayer = newGraphicsLayer;

- m_currentGraphicsLayer->setLinkHighlight(this);

+ m_currentGraphicsLayer->addLinkHighlight(this);

}

return renderLayer;

@@ -283,7 +283,7 @@ void LinkHighlight::startHighlightAnimationIfNeeded()

void LinkHighlight::clearGraphicsLayerLinkHighlightPointer()

{

if (m_currentGraphicsLayer) {

- m_currentGraphicsLayer->setLinkHighlight(0);

+ m_currentGraphicsLayer->removeLinkHighlight(this);

m_currentGraphicsLayer = 0;

}

« no previous file with comments | « Source/core/platform/graphics/GraphicsLayer.cpp ('k') | Source/web/WebViewImpl.h » ('j') | no next file with comments »