Issue 156623005: Add transfer size paramater to didFinishLoading [3/3]

Issue 156623005: Add transfer size paramater to didFinishLoading [3/3] (Closed)

Created:
6 years, 10 months ago by eustas

Modified:
6 years, 10 months ago

Reviewers:
vsevik, jochen (gone - plz use gerrit)

CC:
blink-reviews, jamesr, caseq+blink_chromium.org, aandrey+blink_chromium.org, arv+blink, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add transfer size paramater to didFinishLoading [3/3] Mini DD: https://docs.google.com/a/chromium.org/document/d/1kAKnBKofLc3Tex_JPveubwJcQLT3BhIL3xNQyjvRIps/edit?usp=sharing BUG=111052 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166909

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -62 lines)			Patch
M	Source/core/fetch/FetchContext.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/fetch/FetchContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/fetch/ResourceFetcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/fetch/ResourceFetcher.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/fetch/ResourceLoader.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/fetch/ResourceLoader.cpp	View		6 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/core/fetch/ResourceLoaderHost.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorResourceAgent.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorResourceAgent.cpp	View		4 chunks	+7 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/FrameFetchContext.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/FrameFetchContext.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/loader/PingLoader.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/NetworkManager.js	View		6 chunks	+12 lines, -6 lines	0 comments	Download
M	Source/devtools/front_end/NetworkRequest.js	View		2 chunks	+9 lines, -18 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/web/tests/AssociatedURLLoaderTest.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebURLLoaderClient.h	View		1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/156623005/diff/1/Source/core/loader/FrameFetchContext.cpp File Source/core/loader/FrameFetchContext.cpp (right): https://chromiumcodereview.appspot.com/156623005/diff/1/Source/core/loader/FrameFetchContext.cpp#newcode207 Source/core/loader/FrameFetchContext.cpp:207: dispatchDidFinishLoading(ensureLoader(loader), identifier, 0, blink::WebURLLoaderClient::kUnknownEncodedDataLength); 0, we have loaded ...

6 years, 10 months ago (2014-02-07 09:37:07 UTC) #3

eustas

https://chromiumcodereview.appspot.com/156623005/diff/1/Source/core/loader/FrameFetchContext.cpp File Source/core/loader/FrameFetchContext.cpp (right): https://chromiumcodereview.appspot.com/156623005/diff/1/Source/core/loader/FrameFetchContext.cpp#newcode207 Source/core/loader/FrameFetchContext.cpp:207: dispatchDidFinishLoading(ensureLoader(loader), identifier, 0, blink::WebURLLoaderClient::kUnknownEncodedDataLength); On 2014/02/07 09:37:08, vsevik wrote: ...

6 years, 10 months ago (2014-02-10 12:36:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/156623005/110001

6 years, 10 months ago (2014-02-11 07:44:38 UTC) #6

Message was sent while issue was closed.

Change committed as 166909

Expand Messages | Collapse Messages