Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: components/autofill/browser/autofill_external_delegate.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated regexp, sanitized result, escaped form domain and added comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_external_delegate.cc
diff --git a/components/autofill/browser/autofill_external_delegate.cc b/components/autofill/browser/autofill_external_delegate.cc
index 95fc0cfd74500192a39b715dc7eb5f65b1341a08..6bca5619ec40ed323031ca5bb9a9bc82b7be5c3b 100644
--- a/components/autofill/browser/autofill_external_delegate.cc
+++ b/components/autofill/browser/autofill_external_delegate.cc
@@ -140,6 +140,7 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
void AutofillExternalDelegate::OnShowPasswordSuggestions(
const std::vector<base::string16>& suggestions,
+ const std::vector<base::string16>& origins,
const FormFieldData& field,
const gfx::RectF& element_bounds) {
autofill_query_field_ = field;
@@ -154,7 +155,7 @@ void AutofillExternalDelegate::OnShowPasswordSuggestions(
std::vector<int> password_ids(suggestions.size(),
WebAutofillClient::MenuItemIDPasswordEntry);
autofill_manager_->delegate()->ShowAutofillPopup(
- element_bounds_, suggestions, empty, empty, password_ids, GetWeakPtr());
+ element_bounds_, suggestions, origins, empty, password_ids, GetWeakPtr());
Ilya Sherman 2013/06/06 09:25:35 Hmm. Are the origins really just surfaced as labe
nyquist 2013/06/07 22:51:10 Yes, that is the approved UI. Also changed to |rea
Ilya Sherman 2013/06/07 23:47:56 Hrm, ok. Approved by the Chromium UI leads?
nyquist 2013/06/11 03:36:01 It has been approved for now by UI, but it has not
}
void AutofillExternalDelegate::SetCurrentDataListValues(

Powered by Google App Engine
This is Rietveld 408576698