chrome/android/java/res/layout/autofill_text.xml - Issue 15660018: [autofill] Add support for PSL domain matching for password autofill.

Unified Diff: chrome/android/java/res/layout/autofill_text.xml

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated regexp, sanitized result, escaped form domain and added comments. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/autofill_text.xml

diff --git a/chrome/android/java/res/layout/autofill_text.xml b/chrome/android/java/res/layout/autofill_text.xml

index 08aede0fdd9831e96e4ce4006480b88e52d10310..67e2f3845a4f8e77a341a1e2881ea932d9eaf418 100644

--- a/chrome/android/java/res/layout/autofill_text.xml

+++ b/chrome/android/java/res/layout/autofill_text.xml

@@ -5,28 +5,30 @@

found in the LICENSE file.

-->

-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

- android:layout_height="fill_parent"

- android:layout_width="fill_parent"

- android:background="#FFF"

- android:orientation="horizontal">

- <TextView android:id="@+id/autofill_label"

- android:layout_alignParentEnd="true"

- android:layout_width="wrap_content"

- android:layout_height="fill_parent"

- android:padding="5dp"

- android:textSize="18sp"

- android:textColor="#CCC"

- android:ellipsize="end"

- android:singleLine="true"/>

+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

+ android:id="@+id/autofill_menu_text"

+ android:layout_width="fill_parent"

+ android:layout_height="40dp"

+ android:minHeight="40dp"

+ android:orientation="vertical"

+ android:background="#FFF"

+ android:gravity="center_vertical">

<TextView android:id="@+id/autofill_name"

aurimas (slooooooooow) 2013/06/06 16:52:26 While we are at it lets rename these TextViews to

nyquist 2013/06/07 22:51:10 Done.

android:layout_alignParentStart="true"

android:layout_width="wrap_content"

- android:layout_height="fill_parent"

- android:padding="5dp"

- android:background="#FFF"

+ android:layout_height="wrap_content"

+ android:singleLine="true"

+ android:ellipsize="end"

android:textSize="18sp"

- android:textColor="#000"

+ android:layout_marginStart="5dp"

+ android:layout_marginEnd="5dp" />

+ <TextView android:id="@+id/autofill_label"

+ android:layout_alignParentStart="true"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:singleLine="true"

android:ellipsize="end"

palmer 2013/06/06 21:16:42 Hmm, could long text strings cause user confusion?

nyquist 2013/06/07 22:51:10 Yes, I believe they would. Do you have any suggest

- android:singleLine="true"/>

-</RelativeLayout>

+ android:textSize="14sp"

+ android:layout_marginStart="5dp"

+ android:layout_marginEnd="5dp"/>

+</LinearLayout>