Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: components/autofill/browser/autofill_external_delegate_unittest.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/browser/autofill_external_delegate_unittest.cc b/components/autofill/browser/autofill_external_delegate_unittest.cc
index 24ff7890a919099b52ca69c188b5ce6bd62c3cec..019596045df9d6201592902be3031f6408036fc5 100644
--- a/components/autofill/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/browser/autofill_external_delegate_unittest.cc
@@ -300,8 +300,11 @@ TEST_F(AutofillExternalDelegateUnitTest,
// suggestions.
TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
static const base::string16 kUsername = ASCIIToUTF16("username");
+ static const base::string16 kSignonRealm = ASCIIToUTF16("signon_realm");
Ilya Sherman 2013/06/19 09:40:54 nit: Perhaps use a real example of a signon realm?
nyquist 2013/06/19 22:56:06 Done.
std::vector<base::string16> suggestions;
suggestions.push_back(kUsername);
+ std::vector<base::string16> realms;
+ realms.push_back(kSignonRealm);
FormFieldData field;
field.is_focusable = true;
@@ -324,6 +327,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
_));
external_delegate_->OnShowPasswordSuggestions(suggestions,
+ realms,
field,
element_bounds);

Powered by Google App Engine
This is Rietveld 408576698