Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 5398ac10085d62a084bbaa03aa724f5b861d4871..34af95d24ddd489a311579aabe373150449a18f7 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -303,7 +303,8 @@ void PasswordManager::OnPasswordFormsRendered(
if (provisional_save_manager_->HasGeneratedPassword())
UMA_HISTOGRAM_COUNTS("PasswordGeneration.Submitted", 1);
if (provisional_save_manager_->IsNewLogin() &&
- !provisional_save_manager_->HasGeneratedPassword()) {
+ !provisional_save_manager_->HasGeneratedPassword() &&
+ !provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch()) {
Ilya Sherman 2013/06/19 09:40:54 nit: Could this logic be pushed into the provision
nyquist 2013/06/19 22:56:06 Kept it here for now, but extracted it as the meth
delegate_->AddSavePasswordInfoBarIfPermitted(
provisional_save_manager_.release());
} else {

Powered by Google App Engine
This is Rietveld 408576698