Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Side by Side Diff: components/autofill/browser/autofill_manager.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated regexp, sanitized result, escaped form domain and added comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/browser/autofill_manager.h" 5 #include "components/autofill/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <map> 10 #include <map>
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 void AutofillManager::OnAddPasswordFormMapping( 747 void AutofillManager::OnAddPasswordFormMapping(
748 const FormFieldData& form, 748 const FormFieldData& form,
749 const PasswordFormFillData& fill_data) { 749 const PasswordFormFillData& fill_data) {
750 if (external_delegate_) 750 if (external_delegate_)
751 external_delegate_->AddPasswordFormMapping(form, fill_data); 751 external_delegate_->AddPasswordFormMapping(form, fill_data);
752 } 752 }
753 753
754 void AutofillManager::OnShowPasswordSuggestions( 754 void AutofillManager::OnShowPasswordSuggestions(
755 const FormFieldData& field, 755 const FormFieldData& field,
756 const gfx::RectF& bounds, 756 const gfx::RectF& bounds,
757 const std::vector<base::string16>& suggestions) { 757 const std::vector<base::string16>& suggestions,
758 const std::vector<base::string16>& origins) {
758 if (external_delegate_) 759 if (external_delegate_)
759 external_delegate_->OnShowPasswordSuggestions(suggestions, field, bounds); 760 external_delegate_->OnShowPasswordSuggestions(suggestions,
761 origins,
762 field,
763 bounds);
Ilya Sherman 2013/06/06 09:25:35 nit: Needs curlies now.
nyquist 2013/06/07 22:51:10 Done.
760 } 764 }
761 765
762 void AutofillManager::OnSetDataList(const std::vector<base::string16>& values, 766 void AutofillManager::OnSetDataList(const std::vector<base::string16>& values,
763 const std::vector<base::string16>& labels, 767 const std::vector<base::string16>& labels,
764 const std::vector<base::string16>& icons, 768 const std::vector<base::string16>& icons,
765 const std::vector<int>& unique_ids) { 769 const std::vector<int>& unique_ids) {
766 if (labels.size() != values.size() || 770 if (labels.size() != values.size() ||
767 icons.size() != values.size() || 771 icons.size() != values.size() ||
768 unique_ids.size() != values.size()) { 772 unique_ids.size() != values.size()) {
769 return; 773 return;
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
1316 1320
1317 void AutofillManager::UpdateInitialInteractionTimestamp( 1321 void AutofillManager::UpdateInitialInteractionTimestamp(
1318 const TimeTicks& interaction_timestamp) { 1322 const TimeTicks& interaction_timestamp) {
1319 if (initial_interaction_timestamp_.is_null() || 1323 if (initial_interaction_timestamp_.is_null() ||
1320 interaction_timestamp < initial_interaction_timestamp_) { 1324 interaction_timestamp < initial_interaction_timestamp_) {
1321 initial_interaction_timestamp_ = interaction_timestamp; 1325 initial_interaction_timestamp_ = interaction_timestamp;
1322 } 1326 }
1323 } 1327 }
1324 1328
1325 } // namespace autofill 1329 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698