Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 15660005: Don't use fast literal if the boilerplate map is still deprecated. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Don't use fast literal if the boilerplate map is still deprecated. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14774

Patch Set 1 : Don't migrate when deprecated. Just don't use the fast path. #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/hydrogen.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-23 09:29:46 UTC) #1
mvstanton
Right on. ltgm modulo the request for comment in the code. https://chromiumcodereview.appspot.com/15660005/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): ...
7 years, 7 months ago (2013-05-23 09:47:39 UTC) #2
mvstanton
Okay patch set 3 is good. lgtm.
7 years, 7 months ago (2013-05-23 11:17:15 UTC) #3
Toon Verwaest
7 years, 7 months ago (2013-05-23 11:30:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r14774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698