Issue 15654005: Reset homepage and startup pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15654005: Reset homepage and startup pages (Closed)

Created:
7 years, 7 months ago by vasilii

Modified:
7 years, 7 months ago

Reviewers:
vasilii, commit-bot: I haz the power, battre

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Implemented "Reset homepage" and "Reset startup pages". Implemented corresponding unit tests. BUG=235037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202060

Patch Set 1 #

Patch Set 2 : Polished test #

Patch Set 3 : Fixed ResetStartPage, default startup page is different on CrOS #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -40 lines)			Patch
M	chrome/browser/profile_resetter/profile_resetter.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/profile_resetter/profile_resetter.cc	View		5 chunks	+24 lines, -3 lines	0 comments	Download
M	chrome/browser/profile_resetter/profile_resetter_unittest.cc	View	1 2	1 chunk	+97 lines, -36 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/15654005/11001

7 years, 7 months ago (2013-05-24 07:39:02 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=131489

7 years, 7 months ago (2013-05-24 10:02:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/15654005/11001

7 years, 7 months ago (2013-05-24 10:27:51 UTC) #5

Message was sent while issue was closed.

Change committed as 202060

Expand Messages | Collapse Messages