Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15653003: Remove last remnants of ENABLE_SVG (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, pdr, f(malita), Stephen Chennney
Visibility:
Public.

Description

Remove last remnants of ENABLE_SVG The remaining references to the ENABLE_SVG flag were hidden in various .idl and .in syntaxes (Conditional=, conditional=, and condition=). Removed all those, and the ENABLE_SVG define from features.gypi. R=eseidel, pdr BUG=240006 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151438

Patch Set 1 #

Total comments: 4

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -534 lines) Patch
M Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMExceptions.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventNames.in View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/ElementTimeControl.idl View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/svg/SVGAltGlyphDefElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAngle.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateColorElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedAngle.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedEnumeration.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedLength.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedLengthList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumberList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedPreserveAspectRatio.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedRect.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedString.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedTransformList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGCircleElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.idl View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/svg/SVGColor.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.idl View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGDefsElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGDescElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGDocument.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElementInstance.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElementInstanceList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGException.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGExternalResourcesRequired.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEBlendElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFECompositeElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFEDistantLightElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEFloodElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEFuncAElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEFuncBElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEFuncGElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEFuncRElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFEMergeElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFEOffsetElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEPointLightElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFESpotLightElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFETileElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceNameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGGElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGGlyphElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/svg/SVGHKernElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.idl View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/svg/SVGLangSpace.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLength.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGLengthList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGLineElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGLocatable.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMPathElement.idl View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.idl View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGMaskElement.idl View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGMatrix.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGMetadataElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGMissingGlyphElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumber.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGNumberList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPaint.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPathSeg.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegArcRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegClosePath.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPatternElement.idl View 1 chunk +7 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPoint.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPointList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPolylineElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGRect.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGRectElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGRenderingIntent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +7 lines, -9 lines 0 comments Download
M Source/core/svg/SVGScriptElement.idl View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/svg/SVGSetElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGStopElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGStringList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGStyleElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGStyledElement.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.idl View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGSymbolElement.idl View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTRefElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTSpanElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGTests.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGTitleElement.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTransform.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGTransformList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGTransformable.idl View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGURIReference.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUnitTypes.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.idl View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/svg/SVGVKernElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewElement.idl View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGViewSpec.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGZoomEvent.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adamk
7 years, 6 months ago (2013-05-29 21:11:33 UTC) #1
pdr.
Incredible! Thank you for doing this. LGTM https://codereview.chromium.org/15653003/diff/1/Source/core/svg/SVGAnimationElement.idl File Source/core/svg/SVGAnimationElement.idl (right): https://codereview.chromium.org/15653003/diff/1/Source/core/svg/SVGAnimationElement.idl#newcode27 Source/core/svg/SVGAnimationElement.idl:27: NoInterfaceObject, extra ...
7 years, 6 months ago (2013-05-29 21:17:44 UTC) #2
adamk
https://codereview.chromium.org/15653003/diff/1/Source/core/svg/SVGAnimationElement.idl File Source/core/svg/SVGAnimationElement.idl (right): https://codereview.chromium.org/15653003/diff/1/Source/core/svg/SVGAnimationElement.idl#newcode27 Source/core/svg/SVGAnimationElement.idl:27: NoInterfaceObject, On 2013/05/29 21:17:44, pdr wrote: > extra comma ...
7 years, 6 months ago (2013-05-29 21:30:22 UTC) #3
abarth-chromium
rs=me LGTM
7 years, 6 months ago (2013-05-29 21:49:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/15653003/5001
7 years, 6 months ago (2013-05-29 23:09:12 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 03:42:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 151438

Powered by Google App Engine
This is Rietveld 408576698