Add LeakSanitizer annotations to base/debug/leak_annotations.h

Add LeakSanitizer annotations to base/debug/leak_annotations.h

If building with LeakSanitizer, define leak annotations appropriately.
http://clang.llvm.org/docs/LeakSanitizer.html

R=glider@chromium.org,jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206167

[earthdok, 2013-06-11 16:35:20]

Please take a look.

[jar (doing other things), 2013-06-12 18:43:59]

I'm not very familiar with this code, and would like to hear more informed
comments before my rubber stamp is applied.

https://codereview.chromium.org/15652009/diff/1/base/debug/leak_annotations.h
File base/debug/leak_annotations.h (right):

https://codereview.chromium.org/15652009/diff/1/base/debug/leak_annotations.h...
base/debug/leak_annotations.h:52: ScopedLeakSanitizerDisabler(const
ScopedLeakSanitizerDisabler&);
explicit?

[Alexander Potapenko, 2013-06-13 10:47:56]

LGTM in general

https://codereview.chromium.org/15652009/diff/1/base/debug/leak_annotations.h
File base/debug/leak_annotations.h (right):

https://codereview.chromium.org/15652009/diff/1/base/debug/leak_annotations.h...
base/debug/leak_annotations.h:15: // Annotate a program scope as having memory
leaks. Tcmalloc's heap leak
Can you please move the descriptions of the annotations to the top of the file?
Make sure to reflect the difference between their semantics in Heapcheck and
LSan.

[earthdok, 2013-06-13 11:54:08]

- rewrote the comments
- used the DISALLOW_COPY_AND_ASSIGN macro
- got rid of namespace

[Alexander Potapenko, 2013-06-13 13:41:27]

https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotations.h
File base/debug/leak_annotations.h (right):

https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotation...
base/debug/leak_annotations.h:23: // LeakSanitizer won't).
What about annotating the same object twice?

https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotation...
base/debug/leak_annotations.h:25: #define LEAK_SANITIZER 1
Looks like you've forgotten to delete this.

[earthdok, 2013-06-13 13:52:02]

https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotations.h
File base/debug/leak_annotations.h (right):

https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotation...
base/debug/leak_annotations.h:23: // LeakSanitizer won't).
On 2013/06/13 13:41:27, Alexander Potapenko wrote:
> What about annotating the same object twice?

It's actually not a fatal error in HeapChecker. I was wrong before.

https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotation...
base/debug/leak_annotations.h:25: #define LEAK_SANITIZER 1
On 2013/06/13 13:41:27, Alexander Potapenko wrote:
> Looks like you've forgotten to delete this.

Committed accidentally. Fixed.

[Alexander Potapenko, 2013-06-13 13:58:05]

> It's actually not a fatal error in HeapChecker. I was wrong before.
Yeah, and the comment was obsolete. It has been fixed in tcmalloc two years ago.
>
https://codereview.chromium.org/15652009/diff/7001/base/debug/leak_annotation...
> base/debug/leak_annotations.h:25: #define LEAK_SANITIZER 1
> On 2013/06/13 13:41:27, Alexander Potapenko wrote:
> > Looks like you've forgotten to delete this.
> 
> Committed accidentally. Fixed.

LGTM, but need Jim's approval as well.

[jar (doing other things), 2013-06-13 17:21:58]

Mostly rubber stamp LGTM

[commit-bot: I haz the power, 2013-06-13 17:41:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/earthdok@google.com/15652009/11001

[commit-bot: I haz the power, 2013-06-13 22:30:34]

Change committed as 206167