Let HTMLTablePartElement::findParentTable() about come across shadow boundary.

Let HTMLTablePartElement::findParentTable() about come across shadow boundary.

Things like style figuring out <td> style need some tree traversal,
which is this findParentTable() is for. Without this change,
Any <table border> in host world doesn' affect <td> in shadow.

BUG=234040
TEST=table-border.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151826

[Hajime Morrita, 2013-06-03 07:04:58]

Hi, could you take a look?

[hayato, 2013-06-03 07:17:06]

https://codereview.chromium.org/15652006/diff/1/Source/core/html/HTMLTablePar...
File Source/core/html/HTMLTablePartElement.cpp (right):

https://codereview.chromium.org/15652006/diff/1/Source/core/html/HTMLTablePar...
Source/core/html/HTMLTablePartElement.cpp:87: ContainerNode* parent =
parentOrShadowHostElement();
What about a node which is distributed into an insertion point?

I am curious what happens if <td> is is distributed into an insertion point.

[Hajime Morrita, 2013-06-03 08:24:37]

Good point. it won't get any style. Should we use the worker here? I'm not
sure...

[hayato, 2013-06-03 08:40:47]

On 2013/06/03 08:24:37, morrita1 wrote:
> Good point. it won't get any style. Should we use the worker here? I'm not
> sure...

I think we should use a walker here. I am also worried about the performance
impact if we use the walker here.

[Hajime Morrita, 2013-06-03 08:57:06]

Turns out it works without the walker. I added tests for covering distribution
cases.

[Hajime Morrita, 2013-06-03 08:58:31]

No, these tests are too naive.
Umm.

[Hajime Morrita, 2013-06-05 07:17:13]

Revised to use NodeRenderingTraversal.

I don't think this one has significant performance implication.
It is hit only by attribute changes and insertions of table-family elements.

[hayato, 2013-06-05 09:28:57]

lgtm

https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
File LayoutTests/fast/dom/shadow/table-border.html (right):

https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
LayoutTests/fast/dom/shadow/table-border.html:16: <div id="host4">
Could you include '<td>M</td>' here declaratively?

https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
LayoutTests/fast/dom/shadow/table-border.html:27: shadow4.innerHTML = "<table
border><tr id='contentParent'></tr></table>";
Looks like you can include '<content></content>' here instead of inserting that
later imperatively.

[Hajime Morrita, 2013-06-05 09:32:45]

On 2013/06/05 09:28:57, hayato wrote:
> lgtm
> 
>
https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
> File LayoutTests/fast/dom/shadow/table-border.html (right):
> 
>
https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
> LayoutTests/fast/dom/shadow/table-border.html:16: <div id="host4">
> Could you include '<td>M</td>' here declaratively?
No I cannot. Parser prevents me and inserted some extra elements.

> 
>
https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
> LayoutTests/fast/dom/shadow/table-border.html:27: shadow4.innerHTML = "<table
> border><tr id='contentParent'></tr></table>";
> Looks like you can include '<content></content>' here instead of inserting
that
> later imperatively.
Ditto.

[commit-bot: I haz the power, 2013-06-05 09:32:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/15652006/10001

[hayato, 2013-06-05 10:46:55]

On 2013/06/05 09:32:45, morrita1 wrote:
> On 2013/06/05 09:28:57, hayato wrote:
> > lgtm
> > 
> >
I see. That makes sense.

>
https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
> > File LayoutTests/fast/dom/shadow/table-border.html (right):
> > 
> >
>
https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
> > LayoutTests/fast/dom/shadow/table-border.html:16: <div id="host4">
> > Could you include '<td>M</td>' here declaratively?
> No I cannot. Parser prevents me and inserted some extra elements.
> 
> > 
> >
>
https://codereview.chromium.org/15652006/diff/10001/LayoutTests/fast/dom/shad...
> > LayoutTests/fast/dom/shadow/table-border.html:27: shadow4.innerHTML =
"<table
> > border><tr id='contentParent'></tr></table>";
> > Looks like you can include '<content></content>' here instead of inserting
> that
> > later imperatively.
> Ditto.

[commit-bot: I haz the power, 2013-06-05 11:09:04]

Change committed as 151826