Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
15650014:
Add --private option to git_cl.py (Closed)
|
Created:
7 years, 7 months ago by tyoshino (SeeGerritForStatus) Modified:
7 years, 3 months ago CC:
M-A Ruel, chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org Visibility:
Public. |
DescriptionAdd --private option to git_cl.py
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Messages
Total messages: 8 (0 generated)
I'm personally ambivalent so I'll defer the review, sorry.
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/15650014/5001
Presubmit check for 15650014-5001 failed and returned exit status 1. INFO:root:Found 2 file(s). INFO:PRESUBMIT:Running pylint on 60 files Running presubmit commit checks ... Running /b/commit-queue/workdir/tools/depot_tools/PRESUBMIT.py Running tests/gclient_utils_test.py Running tests/watchlists_unittest.py Running tests/checkout_test.py Running tests/scm_unittest.py Running tests/gcl_unittest.py Running tests/patch_test.py Running tests/fix_encoding_test.py Running tests/presubmit_unittest.py Running tests/trychange_unittest.py Running tests/rietveld_test.py Running tests/owners_unittest.py Running tests/breakpad_unittest.py Running tests/gclient_test.py Running tests/gclient_smoketest.py Running tests/subprocess2_test.py Running tests/git_cl_test.py Running tests/gclient_scm_test.py INFO:root:/usr/bin/python /b/google_appengine/dev_appserver.py . --port 8080 --storage /tmp/rietveld_testCUFblo --clear_search_indexes --skip_sdk_update_check Setting up test upstream git repo... Setting up test git repo... TESTING: uploading to bogus server test | 1 + 1 file changed, 1 insertion(+) Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies Running presubmit upload checks ... Presubmit checks passed. Upload server: http://bogus.example.com:80 (change with -s/--server) Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies Got exception while uploading -- saving description to /home/chrome-bot/.git_cl_description_backup TESTING: description was backed up PASS Setting up test upstream git repo... Setting up test git repo... TESTING: git-cl upload wants a server TESTING: git-cl status has no issue TESTING: upload succeeds (needs a server running on localhost) WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. TESTING: git-cl status now knows the issue % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 77 0 0 100 77 0 1399 --:--:-- --:--:-- --:--:-- 1425 TESTING: Base URL contains branch name TESTING: git-cl push ok Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies Running presubmit commit checks ... Presubmit checks passed. Description: 'foo-quux\n\nReview URL: http://localhost:8080/5629499534213120' Closing issue (you may be prompted for your codereview password)... TESTING: committed code has proper description TESTING: issue no longer has a branch TESTING: upstream repo has our commit PASS Setting up test SVN repo... Setting up test git-svn repo... The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to Branch feature_branch set up to track local ref refs/remotes/trunk. TESTING: Guessing upstream branch for refs/remotes/trunk The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to Branch feature_branch set up to track local ref refs/remotes/some_branch. TESTING: Guessing upstream branch for refs/remotes/some_branch PASS Setting up test SVN repo... Setting up test git-svn repo... TESTING: upload succeeds WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. TESTING: git-cl dcommits ok Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies Running presubmit commit checks ... Presubmit checks passed. Description: 'test\n\nBUG=\n\nReview URL: http://localhost:8080/5910974510923776' Closing issue (you may be prompted for your codereview password)... PASS Setting up test SVN repo... Setting up test git-svn repo... TESTING: upload succeeds WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. Switched to branch 'master' Deleted branch abandoned (was 8a514d9). TESTING: git-cl status dropped abandoned branch PASS Setting up test SVN repo... Setting up test remote git-svn-submodule repo... Switched to branch 'master' TESTING: dcommitted code Switched to branch 'git-cl-cherry-pick' Using 50% similarity for rename/copy detection. Override with --similarity. Description: 'dcommit' TESTING: svn got new revision TESTING: svn diff is correct TESTING: git svn fetch gets new svn revision PASS Setting up test upstream git repo... Setting up test git repo... TESTING: upload succeeds (needs a server running on localhost) WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. PASS Setting up test SVN repo... Setting up test git-svn repo... TESTING: git-cl upload hook fails Command "git --no-pager config rietveld.server" failed. Could not find settings file. You must configure your review setup by running "git cl config". TESTING: git-cl dcommit hook fails Command "git --no-pager config rietveld.server" failed. Could not find settings file. You must configure your review setup by running "git cl config". PASS Setting up test SVN repo... Setting up test git-svn repo... TESTING: dcommitted code Using 50% similarity for rename/copy detection. Override with --similarity. Description: 'dcommit' TESTING: post-cl-dcommit hook executed PASS Setting up test upstream git repo... Setting up test git repo... TESTING: upload succeeds (needs a server running on localhost) WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. TESTING: description shouldn't contain unrelated commits PASS Setting up test SVN repo... Setting up test git-svn repo... TESTING: upload succeeds (needs a server running on localhost) WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. TESTING: git-cl status now knows the issue TESTING: git cl patch 5981343255101440 PASS Setting up test SVN repo... Setting up test git-svn repo... TESTING: git-cl upload wants a server TESTING: git-cl status has no issue TESTING: upload succeeds (needs a server running on localhost) WARNING: Use -t or --title to set the title of the patchset. In the near future, -m or --message will send a message instead. See http://goo.gl/JGg0Z for details. TESTING: git-cl status now knows the issue % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 77 0 0 100 77 0 1602 --:--:-- --:--:-- --:--:-- 1638 TESTING: git-cl dcommits ok Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies Running presubmit commit checks ... Presubmit checks passed. Description: 'foo-quux\n\nReview URL: http://localhost:8080/5840605766746112' Closing issue (you may be prompted for your codereview password)... TESTING: dcommitted code has proper description TESTING: issue no longer has a branch TESTING: upstream svn has our commit PASS Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** tests/gclient_smoketest.py failed testConfig (__main__.GClientSmoke) ... ok testDifferentTopLevelDirectory (__main__.GClientSmoke) ... ok testHelp (__main__.GClientSmoke) testHelp: make sure no new command was added. ... FAIL testNotConfigured (__main__.GClientSmoke) ... ok testSolutionNone (__main__.GClientSmoke) ... ok testUnknown (__main__.GClientSmoke) ... FAIL testMultiSolutions (__main__.GClientSmokeBoth) ... ok testMultiSolutionsJobs (__main__.GClientSmokeBoth) ... ok testMultiSolutionsMultiRev (__main__.GClientSmokeBoth) ... ok testRecurse (__main__.GClientSmokeBoth) ... ok testRevInfo (__main__.GClientSmokeBoth) ... ok testRest (__main__.GClientSmokeFromCheckout) ... ok testRevInfo (__main__.GClientSmokeFromCheckout) ... ok testRevertAndStatus (__main__.GClientSmokeFromCheckout) ... ok testRunHooks (__main__.GClientSmokeFromCheckout) ... ok testSync (__main__.GClientSmokeFromCheckout) ... ok testRevInfo (__main__.GClientSmokeGIT) ... ok testRevertAndStatus (__main__.GClientSmokeGIT) ... ok testRunHooks (__main__.GClientSmokeGIT) ... ok testSync (__main__.GClientSmokeGIT) ... ok testSyncIgnoredSolutionName (__main__.GClientSmokeGIT) TODO(maruel): This will become an error soon. ... ok testSyncJobs (__main__.GClientSmokeGIT) ... ok testSyncNoSolutionName (__main__.GClientSmokeGIT) ... ok testCorrectDirectory (__main__.GClientSmokeSVN) ... ok testInitialCheckoutFailed (__main__.GClientSmokeSVN) ... ok testInitialCheckoutNotYetDone (__main__.GClientSmokeSVN) ... ok testRevInfo (__main__.GClientSmokeSVN) ... ok testRevInfoAltDeps (__main__.GClientSmokeSVN) ... ok testRevertAndStatus (__main__.GClientSmokeSVN) ... ok testRevertAndStatusDepsOs (__main__.GClientSmokeSVN) ... ok testRunHooks (__main__.GClientSmokeSVN) ... ok testRunHooksDepsOs (__main__.GClientSmokeSVN) ... ok testSync (__main__.GClientSmokeSVN) ... ok testSyncCust… (message too large)
Expectation in the smoke test needs to be updated. Sent a CL for review. https://codereview.chromium.org/16058007/
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/15650014/5001
Message was sent while issue was closed.
Change committed as 202865 |
