Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 15649020: Enable visual styles for content_shell.exe, so that tooltips can work when hover around an element … (Closed)

Created:
7 years, 6 months ago by zhchbin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable visual styles for content_shell.exe, so that tooltips can work when hover around an element with title attribution. BUG=239437 TEST=Run content_shell.exe and go to http://xkcd.com, hover around the image in the middle should show the tooltips. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203914

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Do not find copies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A content/shell/app/shell.exe.manifest View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
zhchbin
@johen, Please review.
7 years, 6 months ago (2013-06-01 00:23:02 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 6 months ago (2013-06-03 11:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/15649020/1
7 years, 6 months ago (2013-06-03 13:50:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/shell/app/shell.exe.manifest: While running patch -p1 --forward --force --no-backup-if-mismatch; A content/shell/app/shell.exe.manifest ...
7 years, 6 months ago (2013-06-03 13:50:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/15649020/6001
7 years, 6 months ago (2013-06-03 14:07:07 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/shell/app/shell.exe.manifest: While running patch -p1 --forward --force --no-backup-if-mismatch; A content/shell/app/shell.exe.manifest ...
7 years, 6 months ago (2013-06-03 14:07:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/15649020/11001
7 years, 6 months ago (2013-06-03 14:37:27 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/shell/app/shell.exe.manifest: While running patch -p1 --forward --force --no-backup-if-mismatch; A content/shell/app/shell.exe.manifest ...
7 years, 6 months ago (2013-06-03 14:37:29 UTC) #8
zhchbin
On 2013/06/03 14:37:29, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
7 years, 6 months ago (2013-06-03 15:53:08 UTC) #9
方觉(Fang Jue)
On 2013/06/03 15:53:08, zhchbin wrote: > On 2013/06/03 14:37:29, I haz the power (commit-bot) wrote: ...
7 years, 6 months ago (2013-06-04 01:39:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/15649020/15001
7 years, 6 months ago (2013-06-04 01:52:37 UTC) #11
zhchbin
On 2013/06/04 01:39:36, 方觉(Fang Jue) wrote: > On 2013/06/03 15:53:08, zhchbin wrote: > > On ...
7 years, 6 months ago (2013-06-04 01:57:08 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-04 02:22:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/15649020/15001
7 years, 6 months ago (2013-06-04 02:33:40 UTC) #14
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 10:40:14 UTC) #15
Message was sent while issue was closed.
Change committed as 203914

Powered by Google App Engine
This is Rietveld 408576698