Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 15647018: Add read support to PNaClTranslationCache (Closed)

Created:
7 years, 6 months ago by Derek Schuff
Modified:
7 years, 6 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add read support to PNaClTranslationCache Uses most of the same logic from PNaClTranslationCacheWriteEntry (now renamed PNaClTranslationCacheEntry). There is a little ugliness because of the asymmetry in the string type (const ref for write vs pointer for read) but I'm not 100% sure yet that it will stay as strings. R=jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204354 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204896

Patch Set 1 #

Total comments: 13

Patch Set 2 : review comments #

Patch Set 3 : use smaller 'large' file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -130 lines) Patch
M chrome/browser/nacl_host/pnacl_translation_cache.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/nacl_host/pnacl_translation_cache.cc View 1 2 8 chunks +155 lines, -94 lines 0 comments Download
M chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc View 1 2 2 chunks +99 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Derek Schuff
7 years, 6 months ago (2013-06-04 23:38:41 UTC) #1
jvoung (off chromium)
https://codereview.chromium.org/15647018/diff/1/chrome/browser/nacl_host/pnacl_translation_cache.cc File chrome/browser/nacl_host/pnacl_translation_cache.cc (right): https://codereview.chromium.org/15647018/diff/1/chrome/browser/nacl_host/pnacl_translation_cache.cc#newcode80 chrome/browser/nacl_host/pnacl_translation_cache.cc:80: void ReadEntry(int offset, int len); extra space between functions ...
7 years, 6 months ago (2013-06-05 00:42:27 UTC) #2
Derek Schuff
https://codereview.chromium.org/15647018/diff/1/chrome/browser/nacl_host/pnacl_translation_cache.cc File chrome/browser/nacl_host/pnacl_translation_cache.cc (right): https://codereview.chromium.org/15647018/diff/1/chrome/browser/nacl_host/pnacl_translation_cache.cc#newcode80 chrome/browser/nacl_host/pnacl_translation_cache.cc:80: void ReadEntry(int offset, int len); On 2013/06/05 00:42:28, jvoung ...
7 years, 6 months ago (2013-06-05 05:01:59 UTC) #3
jvoung (off chromium)
LGTM One more test idea is to have a way to fill the cache (maybe ...
7 years, 6 months ago (2013-06-05 17:52:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/15647018/11001
7 years, 6 months ago (2013-06-05 18:10:57 UTC) #5
Derek Schuff
On 2013/06/05 17:52:29, jvoung (cr) wrote: > LGTM > > One more test idea is ...
7 years, 6 months ago (2013-06-05 18:11:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/15647018/11001
7 years, 6 months ago (2013-06-05 22:57:56 UTC) #7
commit-bot: I haz the power
Change committed as 204354
7 years, 6 months ago (2013-06-05 23:26:55 UTC) #8
Derek Schuff
On 2013/06/05 23:26:55, I haz the power (commit-bot) wrote: > Change committed as 204354 this ...
7 years, 6 months ago (2013-06-07 16:29:27 UTC) #9
jvoung (off chromium)
lgtm
7 years, 6 months ago (2013-06-07 16:40:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/15647018/32001
7 years, 6 months ago (2013-06-07 16:45:11 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 19:27:09 UTC) #12
Message was sent while issue was closed.
Change committed as 204896

Powered by Google App Engine
This is Rietveld 408576698