Omnibox: Rebuild HQP Cache if it's old

Omnibox: Rebuild HQP Cache if it's old

Make sure the HQP data file is rebuilt from the on-disk history database
at least once a week.  If this doesn't happen, the HQP will grow without
bound.  Every time a URL is visited, it has the opportunity to be added
to the index.  The HQP never expires anything from its index; it currently
only gets rid of only entries by rebuilding the cache from history.
Hence, we need to force rebuilds regularly.

A side effect of this change, which bumps the HQP's cache version
number, will cause all clients to rebuild their HQP database on the
first restart after this update.

BUG=230605, 178705, 237703, 168933
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204985

[Mark P, 2013-06-06 23:54:15]

Hopefully this'll fix all the HQP slowness issues.

--mark

[Peter Kasting, 2013-06-07 00:39:55]

LGTM

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
File chrome/browser/history/url_index_private_data.cc (right):

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
chrome/browser/history/url_index_private_data.cc:1053: // Cache is more than a
week old or, somehow, from some time in the future.
Now() can change with system clock changes like time zone switches, DST, etc. 
We probably don't want to rebuild on every one of those.  Maybe we should allow
the database to be e.g. up to one day in the future?

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
File chrome/browser/history/url_index_private_data.h (right):

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
chrome/browser/history/url_index_private_data.h:340: // instance was built from
history right now, this time will be about Now().
This last sentence seems unnecessary.

[Mark P, 2013-06-07 00:50:27]

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
File chrome/browser/history/url_index_private_data.cc (right):

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
chrome/browser/history/url_index_private_data.cc:1053: // Cache is more than a
week old or, somehow, from some time in the future.
On 2013/06/07 00:39:55, Peter Kasting wrote:
> Now() can change with system clock changes like time zone switches, DST, etc. 
> We probably don't want to rebuild on every one of those.  Maybe we should
allow
> the database to be e.g. up to one day in the future?

Sounds good to me.  Done.

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
File chrome/browser/history/url_index_private_data.h (right):

https://codereview.chromium.org/15645012/diff/2001/chrome/browser/history/url...
chrome/browser/history/url_index_private_data.h:340: // instance was built from
history right now, this time will be about Now().
On 2013/06/07 00:39:55, Peter Kasting wrote:
> This last sentence seems unnecessary.

Okay.  Dropped.

[commit-bot: I haz the power, 2013-06-07 00:50:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/15645012/8001

[commit-bot: I haz the power, 2013-06-07 02:30:27]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-07 13:32:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/15645012/8001

[commit-bot: I haz the power, 2013-06-07 14:05:49]

Retried try job too often on linux_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-07 19:22:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/15645012/39001

[commit-bot: I haz the power, 2013-06-08 00:04:03]

Change committed as 204985