[rAC] Allow sub-views to trigger layout reflow.

[rAC] Allow sub-views to trigger layout reflow.

BUG=157274
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202642

[groby-ooo-7-16, 2013-05-22 22:30:12]

Here's the layout notification workflow I talked about.

Basically, any given subview no matter where in the hierarchy can invoke
requestLayout on the AutofillDialogWindowController (in
autofill_dialog_cocoa.mm)

That in turn queries subviews for preferred sizes (preferredSize message), sets
their frames accordingly, and relayouts via performLayout. 

Both of these messages do delegate to subviews for their size/layout issues.

This CL is not currently invoking requestLayout, just using
preferredSize/performLayout. I've got a second CL that does use requestLayout,
but it's bringing an entire new view with it.

[Robert Sesek, 2013-05-23 15:30:16]

This is a nice way to handle the problem. I don't think it actually buys you
anything, but you could make the preferredSize/performLayout a @protocol to
formalize this convention.

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:38: for
(AutofillSectionContainer* container in [details_ objectEnumerator])
details_.get() instead of objectEnumerator

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:48: [details_
objectEnumerator]) {
same

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm (right):

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:177: else {
If any branch has braces, all branches need braces.

[groby-ooo-7-16, 2013-05-24 20:36:14]

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:38: for
(AutofillSectionContainer* container in [details_ objectEnumerator])
On 2013/05/23 15:30:16, rsesek wrote:
> details_.get() instead of objectEnumerator

Done.

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:48: [details_
objectEnumerator]) {
On 2013/05/23 15:30:16, rsesek wrote:
> same

Done.

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm (right):

https://codereview.chromium.org/15645004/diff/2001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:177: else {
On 2013/05/23 15:30:16, rsesek wrote:
> If any branch has braces, all branches need braces.

Done.

[Robert Sesek, 2013-05-24 20:49:23]

LGTM with nits!

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:48:
details_.get()) {
nit: indent 4 spaces for continuation

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm (right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:184: contentSize =
[mainContainer_ preferredSize];
These two if-branches are the same.

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:200:
!NSEqualRects(ui::kWindowSizeDeterminedLater, [[self window] frame]);
nit: continuation -> indent 4

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_layout.h (right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_layout.h:14: // * subview indicates by
calling -requestRelayout on the window controller.
nit: capitalize 's' in subview

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
(right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm:63: }
else   if ([view isKindOfClass:[MenuButton class]]) {
nit: else     if spacing

[groby-ooo-7-16, 2013-05-24 23:53:35]

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:48:
details_.get()) {
On 2013/05/24 20:49:23, rsesek wrote:
> nit: indent 4 spaces for continuation

Done.

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm (right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:184: contentSize =
[mainContainer_ preferredSize];
On 2013/05/24 20:49:23, rsesek wrote:
> These two if-branches are the same.

Done.

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm:200:
!NSEqualRects(ui::kWindowSizeDeterminedLater, [[self window] frame]);
On 2013/05/24 20:49:23, rsesek wrote:
> nit: continuation -> indent 4

Done.

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_layout.h (right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_layout.h:14: // * subview indicates by
calling -requestRelayout on the window controller.
On 2013/05/24 20:49:23, rsesek wrote:
> nit: capitalize 's' in subview

Done.

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
File chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
(right):

https://codereview.chromium.org/15645004/diff/8001/chrome/browser/ui/cocoa/au...
chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm:63: }
else   if ([view isKindOfClass:[MenuButton class]]) {
On 2013/05/24 20:49:23, rsesek wrote:
> nit: else     if spacing

Done.

[commit-bot: I haz the power, 2013-05-24 23:53:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/15645004/17001

[commit-bot: I haz the power, 2013-05-25 02:18:42]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-28 18:18:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/15645004/17001

[commit-bot: I haz the power, 2013-05-28 20:29:21]

Change committed as 202642