Issue 15623002: Don't serialize config dictionary in Native Messaging interface.

Issue 15623002: Don't serialize config dictionary in Native Messaging interface. (Closed)

Created:
7 years, 7 months ago by Lambros

Modified:
7 years, 7 months ago

Reviewers:
jamiewalch, Lambros, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't serialize config dictionary in Native Messaging interface. The config dictionary is no longer serialized when passing it between the web-app and the native messaging host. It is still serialized for the NPAPI plugin, however, since it's difficult to return JavaScript objects from a NPAPI plugin. BUG=232135 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202029

Patch Set 1 #

Patch Set 2 : clang-format fixes #

Total comments: 4

Patch Set 3 : Address comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -86 lines)			Patch
M	remoting/host/setup/native_messaging_host.cc	View	1	7 chunks	+21 lines, -38 lines	0 comments	Download
M	remoting/webapp/host_controller.js	View	1 2	4 chunks	+21 lines, -37 lines	0 comments	Download
M	remoting/webapp/host_dispatcher.js	View	1 2	5 chunks	+24 lines, -7 lines	0 comments	Download
M	remoting/webapp/host_native_messaging.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm https://codereview.chromium.org/15623002/diff/2001/remoting/webapp/host_controller.js File remoting/webapp/host_controller.js (right): https://codereview.chromium.org/15623002/diff/2001/remoting/webapp/host_controller.js#newcode259 remoting/webapp/host_controller.js:259: return false; You can just replace "if" with ...

7 years, 7 months ago (2013-05-22 00:54:21 UTC) #2

Lambros

https://codereview.chromium.org/15623002/diff/2001/remoting/webapp/host_controller.js File remoting/webapp/host_controller.js (right): https://codereview.chromium.org/15623002/diff/2001/remoting/webapp/host_controller.js#newcode259 remoting/webapp/host_controller.js:259: return false; On 2013/05/22 00:54:21, Jamie wrote: > You ...

7 years, 7 months ago (2013-05-23 00:22:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/15623002/7001

7 years, 7 months ago (2013-05-24 02:57:15 UTC) #5

Message was sent while issue was closed.

Change committed as 202029

Expand Messages | Collapse Messages