Add InstallerDelegate for watching that a package gets installed

Add InstallerDelegate for watching that a package gets installed

* Class monitors for when the given package has been installed on the device.

* Timeouts added to prevent this from spinning forever.

* Test runs the InstallerDelegate on a separate thread so the Handler events are processed instead of sitting idly.

* An attempt at using BroadcastReceivers was made to catch http://developer.android.com/reference/android/content/Intent.html#ACTION_PACKAGE_ADDED,
but the broadcast is fired when the package is added and not when the package finishes installing.

* Adds dfalcantara@ to OWNERs for app banners directories

NOTRY=true
BUG=341556
TEST=InstallerDelegateTest
R=yfriedman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252189

[gone, 2014-02-10 05:47:55]

Broke this piece off of the rest of the app banners stuff since it's
self-contained.

[Yaron, 2014-02-12 04:37:51]

https://chromiumcodereview.appspot.com/156013005/diff/40001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
(right):

https://chromiumcodereview.appspot.com/156013005/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java:57:
protected Boolean doInBackground(Void... args) {
Not a fan of this..hogging one of the asynctask threads and repeatedly pinging
the package manager. If you have enough of these you could theoretically even
hose the whole threadpool. I'd like to understand better why you can't use
ACTION_PACKAGE_ADDED. Maybe there's some add'l delay or another action you can
use?

[gone, 2014-02-13 02:11:20]

https://codereview.chromium.org/156013005/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
(right):

https://codereview.chromium.org/156013005/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java:57:
protected Boolean doInBackground(Void... args) {
On 2014/02/12 04:37:51, Yaron wrote:
> Not a fan of this..hogging one of the asynctask threads and repeatedly pinging
> the package manager. If you have enough of these you could theoretically even
> hose the whole threadpool. I'd like to understand better why you can't use
> ACTION_PACKAGE_ADDED. Maybe there's some add'l delay or another action you can
> use?

Explained why in the commit log, swapped over to a Handler/Runnable combo.

[Yaron, 2014-02-13 08:45:43]

lgtm

https://codereview.chromium.org/156013005/diff/240001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
(right):

https://codereview.chromium.org/156013005/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java:57:
new Handler().postDelayed(this, 1000);
make member variable

https://codereview.chromium.org/156013005/diff/240001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
(right):

https://codereview.chromium.org/156013005/diff/240001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java:63:
mPackageManager = new TestPackageManager();
Reset other member variables to avoid test interactions

https://codereview.chromium.org/156013005/diff/240001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java:82:
}, MS_MAX_TIME_TO_WAIT, MS_BETWEEN_CHECKS));
This can probably be made faster by mocking the clock but since it's basically
1-2 seconds I'm fine with it. I guess if lots more tests get added we should
adjust it.

[gone, 2014-02-14 05:16:26]

Took a bunch of finessing, but it seems like things are working as expected.

https://codereview.chromium.org/156013005/diff/240001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
(right):

https://codereview.chromium.org/156013005/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java:57:
new Handler().postDelayed(this, 1000);
On 2014/02/13 08:45:43, Yaron wrote:
> make member variable

Well, that took a lot more effort than expected.

https://codereview.chromium.org/156013005/diff/240001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
(right):

https://codereview.chromium.org/156013005/diff/240001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java:63:
mPackageManager = new TestPackageManager();
On 2014/02/13 08:45:43, Yaron wrote:
> Reset other member variables to avoid test interactions

Done.

https://codereview.chromium.org/156013005/diff/240001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java:82:
}, MS_MAX_TIME_TO_WAIT, MS_BETWEEN_CHECKS));
On 2014/02/13 08:45:43, Yaron wrote:
> This can probably be made faster by mocking the clock but since it's basically
> 1-2 seconds I'm fine with it. I guess if lots more tests get added we should
> adjust it.

Made it so that the timers are configurable on the class itself.  Also added a
timeout.

[gone, 2014-02-14 05:16:41]

Oh, can you give it another full pass now, BTW?

[Yaron, 2014-02-19 18:55:41]

lgtm

https://chromiumcodereview.appspot.com/156013005/diff/340001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
(right):

https://chromiumcodereview.appspot.com/156013005/diff/340001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java:73:
mThread = new HandlerThread("InstallerDelegateTest thread") {
I'd |quit| this in tearDown.

[gone, 2014-02-19 21:36:39]

https://chromiumcodereview.appspot.com/156013005/diff/340001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
(right):

https://chromiumcodereview.appspot.com/156013005/diff/340001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java:73:
mThread = new HandlerThread("InstallerDelegateTest thread") {
On 2014/02/19 18:55:41, Yaron wrote:
> I'd |quit| this in tearDown.

Took a little finagling again, but should work now.

[gone, 2014-02-19 21:36:47]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-02-19 21:41:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/156013005/450001

[commit-bot: I haz the power, 2014-02-19 22:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 22:47:53]

Try jobs failed on following builders: mac_chromium_rel

[gone, 2014-02-19 22:49:23]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-02-19 23:18:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/156013005/450001

[commit-bot: I haz the power, 2014-02-20 01:07:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/156013005/450001

[commit-bot: I haz the power, 2014-02-20 01:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 01:31:24]

Try jobs failed on following builders: mac_chromium_rel

[gone, 2014-02-20 01:44:45]

On 2014/02/20 01:31:24, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders: mac_chromium_rel

mac_chromium_rel shouldn't even be affected a Java-only CL.

[gone, 2014-02-20 01:44:48]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-02-20 02:06:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/156013005/450001

[commit-bot: I haz the power, 2014-02-20 05:17:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/156013005/450001

[gone, 2014-02-20 07:58:36]

Committed patchset #10 manually as r252189 (presubmit successful).