Cleanup: Remove unneeded gurl.h includes.

Cleanup: Remove unneeded gurl.h includes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207739

[Lei Zhang, 2013-06-19 06:18:30]

derat: ash
grt: cf
joth: components
piman: content

[Lei Zhang, 2013-06-19 07:20:54]

dbeam: components/autofill
cdn: rubber stamp on content/common/child_process_messages.h

[Dan Beam, 2013-06-19 07:39:45]

components/autofill/ lgtm

[Daniel Erat, 2013-06-19 13:01:13]

ash LGTM

[joth, 2013-06-19 16:27:34]

https://codereview.chromium.org/15600006/diff/39001/components/navigation_int...
File components/navigation_interception/intercept_navigation_delegate.cc
(right):

https://codereview.chromium.org/15600006/diff/39001/components/navigation_int...
components/navigation_interception/intercept_navigation_delegate.cc:82: if
(!navigation_params.url().is_valid())
what's the criteria for 'unneeded'? This is calling methods on GURL, so my
understanding of IWYU is this should include gurl.h ?

[Cris Neckar, 2013-06-19 17:56:37]

rubber stamp lgtm on ipc changes

[piman, 2013-06-19 18:17:19]

lgtm

[Lei Zhang, 2013-06-19 18:49:31]

On 2013/06/19 16:27:34, joth wrote:
>
https://codereview.chromium.org/15600006/diff/39001/components/navigation_int...
> File components/navigation_interception/intercept_navigation_delegate.cc
> (right):
> 
>
https://codereview.chromium.org/15600006/diff/39001/components/navigation_int...
> components/navigation_interception/intercept_navigation_delegate.cc:82: if
> (!navigation_params.url().is_valid())
> what's the criteria for 'unneeded'? This is calling methods on GURL, so my
> understanding of IWYU is this should include gurl.h ?

This is semi-automated with a shell script, so it missed this one. Thanks for
noticing and reverted.

[joth, 2013-06-19 20:52:28]

On 19 June 2013 11:49, <thestig@chromium.org> wrote:

> On 2013/06/19 16:27:34, joth wrote:
>
> https://codereview.chromium.**org/15600006/diff/39001/**
>
components/navigation_**interception/intercept_**navigation_delegate.cc<https://codereview.chromium.org/15600006/diff/39001/components/navigation_interception/intercept_navigation_delegate.cc>
>
>> File components/navigation_**interception/intercept_**
>> navigation_delegate.cc
>> (right):
>>
>
>
> https://codereview.chromium.**org/15600006/diff/39001/**
> components/navigation_**interception/intercept_**navigation_delegate.cc#**
>
newcode82<https://codereview.chromium.org/15600006/diff/39001/components/navigation_interception/intercept_navigation_delegate.cc#newcode82>
>
>> components/navigation_**interception/intercept_**navigation_delegate.cc:82:
>> if
>> (!navigation_params.url().is_**valid())
>> what's the criteria for 'unneeded'? This is calling methods on GURL, so my
>> understanding of IWYU is this should include gurl.h ?
>>
>
> This is semi-automated with a shell script, so it missed this one. Thanks
> for
> noticing and reverted.
>
>
no worries.
Did anyone get the https://code.google.com/p/include-what-you-use/ tool
working on chromium code? I know there was an effort on that a while back.



>
https://codereview.chromium.**org/15600006/<https://codereview.chromium.org/1...
>

[Lei Zhang, 2013-06-19 20:56:23]

On 2013/06/19 20:52:28, joth wrote:
> no worries.
> Did anyone get the https://code.google.com/p/include-what-you-use/ tool
> working on chromium code? I know there was an effort on that a while back.

Not sure. I'll have try it one of these days.

FYI, googleurl/src/gurl.h currently just #includes url/gurl.h. Tfarina@ probably
will come along and move all these, but I wanted to do a pass ahead of him and
get rid of the unused ones.

[grt (UTC plus 2), 2013-06-21 01:20:13]

chrome_frame/ LGTM

[commit-bot: I haz the power, 2013-06-21 01:20:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15600006/40020

[commit-bot: I haz the power, 2013-06-21 06:55:42]

Change committed as 207739