Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15600004: move kInvalidNetAddress to constants file for split_link (Closed)

Created:
7 years, 7 months ago by scottmg
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

move kInvalidNetAddress to constants file for split_link TBR=brettw@chromium.org R=cpu@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M build/split_link_partition.py View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A ppapi/shared_impl/private/net_address_private_impl_constants.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
7 years, 7 months ago (2013-05-21 20:53:51 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 7 months ago (2013-05-21 23:00:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15600004/1
7 years, 7 months ago (2013-05-21 23:14:25 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-21 23:37:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15600004/1
7 years, 7 months ago (2013-05-21 23:46:15 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-22 02:10:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15600004/1
7 years, 7 months ago (2013-05-22 02:34:13 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-22 13:03:36 UTC) #8
Message was sent while issue was closed. 
Change committed as 201505

Powered by Google App Engine
This is Rietveld 408576698