Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1558553002: Lo-Fi snackbar should only be shown for the first q=low response of a page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tbansal comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index e687991a3f51a73ad7955df335fec2aa7b815fe7..f9db5130870a47907c6e82919cf29ed6e7a9f904 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -87,7 +87,6 @@ import org.chromium.chrome.browser.init.AsyncInitializationActivity;
import org.chromium.chrome.browser.metrics.LaunchMetrics;
import org.chromium.chrome.browser.metrics.StartupMetrics;
import org.chromium.chrome.browser.metrics.UmaSessionStats;
-import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
import org.chromium.chrome.browser.nfc.BeamController;
import org.chromium.chrome.browser.nfc.BeamProvider;
import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
@@ -461,6 +460,21 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
TraceEvent.end("ChromeActivity:CompositorInitialization");
}
+ public void showLoFiPopup(Tab tab) {
tbansal1 2016/01/05 21:07:09 Please add javadocs comments for the function.
megjablon 2016/01/06 17:20:47 Done.
+ if (tab.isHidden()) {
+ TabObserver tabObserver = new EmptyTabObserver() {
+ @Override
+ public void onShown(Tab tab) {
+ mLoFiBarPopupController.showLoFiBar(tab);
+ tab.removeObserver(this);
+ }
+ };
+ tab.addObserver(tabObserver);
+ return;
+ }
+ mLoFiBarPopupController.showLoFiBar(tab);
+ }
+
/**
* Sets the {@link TabModelSelector} owned by this {@link ChromeActivity}.
* @param tabModelSelector A {@link TabModelSelector} instance.
@@ -478,24 +492,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
&& DataUseTabUIManager.checkAndResetDataUseTrackingEnded(tab)) {
mDataUseSnackbarController.showDataUseTrackingEndedBar();
}
-
- if (!tab.isNativePage() && !tab.isIncognito()
- && DataReductionProxySettings.getInstance().wasLoFiModeActiveOnMainFrame()
- && DataReductionProxySettings.getInstance().canUseDataReductionProxy(
- tab.getUrl())) {
- if (tab.isHidden()) {
- TabObserver tabObserver = new EmptyTabObserver() {
- @Override
- public void onShown(Tab tab) {
- mLoFiBarPopupController.showLoFiBar(tab);
- tab.removeObserver(this);
- }
- };
- tab.addObserver(tabObserver);
- return;
- }
- mLoFiBarPopupController.showLoFiBar(tab);
- }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698