Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: ui/message_center/message_center.h

Issue 15582004: Move NotificationDelegate into message_center. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the ever-changing Mac unit tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/fake_message_center.cc ('k') | ui/message_center/message_center.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center.h
diff --git a/ui/message_center/message_center.h b/ui/message_center/message_center.h
index 89c0ef241d3e46d17f6804f78927d8fbc0beac8f..7be6cc818831b5cd17a6de627b0851a39c248d89 100644
--- a/ui/message_center/message_center.h
+++ b/ui/message_center/message_center.h
@@ -59,9 +59,6 @@ class MESSAGE_CENTER_EXPORT MessageCenter {
// Request to show the notification settings dialog. |context| is necessary
// to create a new window.
virtual void ShowSettingsDialog(gfx::NativeView context) = 0;
-
- // Request to check if the notification has the listener of Clicked event.
- virtual bool HasClickedListener(const std::string& notification_id) = 0;
};
// Called to set the delegate. Generally called only once, except in tests.
@@ -95,23 +92,24 @@ class MESSAGE_CENTER_EXPORT MessageCenter {
// from the extension. Otherwise if |display_source| is provided, a menu item
// showing the source and allowing notifications from that source to be
// disabled will be shown. All actual disabling is handled by the Delegate.
- virtual void AddNotification(
- NotificationType type,
- const std::string& id,
- const string16& title,
- const string16& message,
- const string16& display_source,
- const std::string& extension_id,
- const base::DictionaryValue* optional_fields) = 0;
+ virtual void AddNotification(NotificationType type,
+ const std::string& id,
+ const string16& title,
+ const string16& message,
+ const string16& display_source,
+ const std::string& extension_id,
+ const base::DictionaryValue* optional_fields,
+ NotificationDelegate* delegate) = 0;
// Updates an existing notification with id = old_id and set its id to new_id.
- // |optional_fields| can be NULL in case of no updates on those fields.
- virtual void UpdateNotification(
- const std::string& old_id,
- const std::string& new_id,
- const string16& title,
- const string16& message,
- const base::DictionaryValue* optional_fields) = 0;
+ // |delegate| and |optional_fields| can be NULL in case of no updates on
+ // those fields.
+ virtual void UpdateNotification(const std::string& old_id,
+ const std::string& new_id,
+ const string16& title,
+ const string16& message,
+ const base::DictionaryValue* optional_fields,
+ NotificationDelegate* delegate) = 0;
// Removes an existing notification.
virtual void RemoveNotification(const std::string& id, bool by_user) = 0;
« no previous file with comments | « ui/message_center/fake_message_center.cc ('k') | ui/message_center/message_center.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698