Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4086)

Unified Diff: chrome/browser/notifications/notification_delegate.h

Issue 15582004: Move NotificationDelegate into message_center. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the ever-changing Mac unit tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/notification.cc ('k') | chrome/browser/notifications/notification_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_delegate.h
diff --git a/chrome/browser/notifications/notification_delegate.h b/chrome/browser/notifications/notification_delegate.h
index 1c579d562b511d7501c5488523bc6bcc1ccbd76e..6ba6171424ce8a2a27c826d904f103f48b107dec 100644
--- a/chrome/browser/notifications/notification_delegate.h
+++ b/chrome/browser/notifications/notification_delegate.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -8,6 +8,7 @@
#include <string>
#include "base/memory/ref_counted.h"
+#include "ui/message_center/notification_delegate.h"
namespace content {
class RenderViewHost;
@@ -16,31 +17,8 @@ class RenderViewHost;
// Delegate for a notification. This class has two roles: to implement callback
// methods for notification, and to provide an identity of the associated
// notification.
-class NotificationDelegate
- : public base::RefCountedThreadSafe<NotificationDelegate> {
+class NotificationDelegate : public message_center::NotificationDelegate {
public:
- // To be called when the desktop notification is actually shown.
- virtual void Display() = 0;
-
- // To be called when the desktop notification cannot be shown due to an
- // error.
- virtual void Error() = 0;
-
- // To be called when the desktop notification is closed. If closed by a
- // user explicitly (as opposed to timeout/script), |by_user| should be true.
- virtual void Close(bool by_user) = 0;
-
- // To be called when a desktop notification is clicked.
- virtual void Click() = 0;
-
- // Returns true if the delegate can handle click event.
- virtual bool HasClickedListener();
-
- // To be called when the user clicks a button in a notification. TODO(miket):
- // consider providing default implementations of the pure virtuals of this
- // interface, to avoid pinging so many OWNERs each time we enhance it.
- virtual void ButtonClick(int button_index);
-
// Returns unique id of the notification.
virtual std::string id() const = 0;
@@ -55,9 +33,6 @@ class NotificationDelegate
protected:
virtual ~NotificationDelegate() {}
-
- private:
- friend class base::RefCountedThreadSafe<NotificationDelegate>;
};
#endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DELEGATE_H_
« no previous file with comments | « chrome/browser/notifications/notification.cc ('k') | chrome/browser/notifications/notification_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698