Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 1557803002: [Custom Tabs] Implement Bottombar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: respond to dfalcantara@'s comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
index f06e3a61af860f9fb7d425d3c683fa548ca1a90b..cdb00f95b21e62d657418a27a7fe8f2c4ae4eb3f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
@@ -371,21 +371,21 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {
@Override
public boolean updateVisuals(final ICustomTabsCallback callback, Bundle bundle) {
+ // TODO(ianwen): add update logic here to support bundle list and bottom bar items.
final Bundle actionButtonBundle = IntentUtils.safeGetBundle(bundle,
CustomTabsIntent.EXTRA_ACTION_BUTTON_BUNDLE);
if (actionButtonBundle == null) return false;
- final Bitmap bitmap = ActionButtonParams.tryParseBitmapFromBundle(mApplication,
- actionButtonBundle);
- final String description = ActionButtonParams
- .tryParseDescriptionFromBundle(actionButtonBundle);
+ final Bitmap bitmap = CustomButtonParams.parseBitmapFromBundle(actionButtonBundle);
+ final String description = CustomButtonParams
+ .parseDescriptionFromBundle(actionButtonBundle);
if (bitmap == null || description == null) return false;
try {
return ThreadUtils.runOnUiThreadBlocking(new Callable<Boolean>() {
@Override
public Boolean call() throws Exception {
- return CustomTabActivity.updateActionButton(callback.asBinder(), bitmap,
+ return CustomTabActivity.updateCustomButton(callback.asBinder(), 0, bitmap,
description);
}
});

Powered by Google App Engine
This is Rietveld 408576698