Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 15565002: Zap map value in the stub-cache on clear. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Zap map value in the stub-cache on clear. The empty_string is a valid key for keyed loads and stores. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14732

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/stub-cache.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-21 12:10:31 UTC) #1
Michael Starzinger
Can we get a regression test for this?
7 years, 7 months ago (2013-05-21 12:14:56 UTC) #2
Michael Starzinger
LGTM. As discussed offline, let's keep working on a repro in a follow-up CL.
7 years, 7 months ago (2013-05-21 12:59:22 UTC) #3
Toon Verwaest
7 years, 7 months ago (2013-05-21 12:59:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698