Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: filter/dscache/ds.go

Issue 1556193002: Replace spammy log message in dscache with comment. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: lol Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/dscache/ds.go
diff --git a/filter/dscache/ds.go b/filter/dscache/ds.go
index 47586d8a309c5901c0fdec70dfadbf29f9e527b2..542ada6b111cf2335a76602acdf94e10addec238 100644
--- a/filter/dscache/ds.go
+++ b/filter/dscache/ds.go
@@ -40,9 +40,9 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu
}
if err := d.mc.AddMulti(lockItems); err != nil {
- (log.Fields{log.ErrorKey: err}).Warningf(
- d.c, "dscache: GetMulti: memcache.AddMulti")
-
+ // Ignore this error. Either we couldn't add them because they exist
+ // (so, not an issue), or because memcache is having sad times (in which
+ // case we'll see so in the GetMulti which immediately follows this).
}
if err := d.mc.GetMulti(lockItems); err != nil {
(log.Fields{log.ErrorKey: err}).Warningf(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698