Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15535005: Added window.testRunner.isChooserShown() (Closed)

Created:
7 years, 7 months ago by Hajime Morrita
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, jochen+watch_chromium.org, abarth-chromium, keishi
Visibility:
Public.

Description

Added window.testRunner.isChooserShown() This change adds testRunner.isChooserShown() and a mock ColorChooser implementation for TestRunner. Without the mock, color pickers aren't recognized as closed. This is a preparation for crbug.com/234810. BUG=234810 TEST=input-color-chooser-shown.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150851

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Total comments: 2

Patch Set 3 : Moved things to WebTestProxy #

Total comments: 1

Patch Set 4 : Moved things WebTestProxy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -36 lines) Patch
A LayoutTests/fast/forms/color/input-color-chooser-shown.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/color/input-color-chooser-shown-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/DumpRenderTree.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h View 1 2 3 6 chunks +13 lines, -0 lines 0 comments Download
A + Tools/DumpRenderTree/chromium/TestRunner/src/MockColorChooser.h View 1 2 2 chunks +17 lines, -17 lines 0 comments Download
A + Tools/DumpRenderTree/chromium/TestRunner/src/MockColorChooser.cpp View 1 2 1 chunk +40 lines, -19 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp View 1 2 3 4 chunks +23 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Hajime Morrita
This is a continuation from https://codereview.chromium.org/15376006/
7 years, 7 months ago (2013-05-21 06:25:37 UTC) #1
tkent
lgtm https://codereview.chromium.org/15535005/diff/1/Source/core/testing/Internals.cpp File Source/core/testing/Internals.cpp (right): https://codereview.chromium.org/15535005/diff/1/Source/core/testing/Internals.cpp#newcode689 Source/core/testing/Internals.cpp:689: nit: You don't need to touch this file. ...
7 years, 7 months ago (2013-05-21 06:33:01 UTC) #2
Hajime Morrita
Thanks! I'll land the revised one.
7 years, 7 months ago (2013-05-21 06:48:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/15535005/4001
7 years, 7 months ago (2013-05-21 06:49:10 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/15535005/diff/4001/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h File Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (right): https://codereview.chromium.org/15535005/diff/4001/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h#newcode107 Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:107: virtual void didOpenChooser() = 0; this will break content_shell, ...
7 years, 7 months ago (2013-05-21 07:11:06 UTC) #5
Hajime Morrita
Jochen, thanks for the catch! I was confused about relationship between these classes. If it's ...
7 years, 7 months ago (2013-05-21 07:32:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/15535005/6002
7 years, 7 months ago (2013-05-21 08:01:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=6473
7 years, 7 months ago (2013-05-21 09:28:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/15535005/6002
7 years, 7 months ago (2013-05-21 10:22:26 UTC) #9
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/15535005/diff/6002/Tools/DumpRenderTree/chromium/WebViewHost.cpp File Tools/DumpRenderTree/chromium/WebViewHost.cpp (right): https://chromiumcodereview.appspot.com/15535005/diff/6002/Tools/DumpRenderTree/chromium/WebViewHost.cpp#newcode126 Tools/DumpRenderTree/chromium/WebViewHost.cpp:126: WebKit::WebColorChooser* WebViewHost::createColorChooser(WebKit::WebColorChooserClient* client, const WebKit::WebColor&) sorry if that was ...
7 years, 7 months ago (2013-05-21 10:34:51 UTC) #10
Hajime Morrita
Ooops. Apparently my understanding around DRT/ContentShell seems insufficient. Thanks for your followup.
7 years, 7 months ago (2013-05-22 00:51:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/15535005/11002
7 years, 7 months ago (2013-05-22 01:36:01 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-22 03:02:07 UTC) #13
Message was sent while issue was closed. 
Change committed as 150851

Powered by Google App Engine
This is Rietveld 408576698