Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 15521008: Add crash_handler to all.gyp for WebRTC build target. (Closed)

Created:
7 years, 7 months ago by kjellander_chromium
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add crash_handler to all.gyp for WebRTC build target. In revision span 200066:200103 some GYP files have changed so that the crash_handler target is no longer built as a part of our chromium_builder_webrtc target. To be able to use it on Windows testers, add it explicitly. TEST=local build on Windows. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201378

Patch Set 1 #

Patch Set 2 : Wrapped into a OS=="win" condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kjellander_chromium
Examples of failures: http://build.chromium.org/p/chromium.webrtc/waterfall
7 years, 7 months ago (2013-05-21 08:04:16 UTC) #1
kjellander_chromium
Examples of failures: http://build.chromium.org/p/chromium.webrtc/waterfall
7 years, 7 months ago (2013-05-21 08:04:17 UTC) #2
phoglund1
lgtm
7 years, 7 months ago (2013-05-21 08:04:53 UTC) #3
phoglund_chromium
lgtm
7 years, 7 months ago (2013-05-21 08:05:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/15521008/1
7 years, 7 months ago (2013-05-21 08:05:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=26459
7 years, 7 months ago (2013-05-21 08:19:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/15521008/22001
7 years, 7 months ago (2013-05-21 18:47:37 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 22:41:46 UTC) #8
Message was sent while issue was closed.
Change committed as 201378

Powered by Google App Engine
This is Rietveld 408576698