Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15521005: Translate (Mac): add after infobar UI for server side language detection (Closed)

Created:
7 years, 7 months ago by Takashi Toyoshima
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, arv+watch_chromium.org, sail+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Translate (Mac): add after infobar UI for server side language detection After enabling context menu to translate unknown language, Chrome needs to modify infobar UX for Chrome Translate. This change fixes Mac UI. BUG=172593 patch from issue 15295004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202399

Patch Set 1 : done #

Patch Set 2 : rename, etc from other platform review #

Patch Set 3 : (rebase and repair) #

Patch Set 4 : feedback from linux/win ports #

Patch Set 5 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/infobars/after_translate_infobar_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/after_translate_infobar_controller.mm View 1 2 3 4 2 chunks +22 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Takashi Toyoshima
Hi rohitrao, Can you review this UI change on Translate infobars for Mac? This change ...
7 years, 7 months ago (2013-05-21 09:39:13 UTC) #1
Takashi Toyoshima
ping
7 years, 7 months ago (2013-05-22 23:59:38 UTC) #2
rohitrao (ping after 24h)
lgtm
7 years, 7 months ago (2013-05-23 00:10:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/15521005/13001
7 years, 7 months ago (2013-05-23 18:04:09 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=153133
7 years, 7 months ago (2013-05-23 23:49:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/15521005/13001
7 years, 7 months ago (2013-05-27 06:22:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/15521005/36001
7 years, 7 months ago (2013-05-27 07:24:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/15521005/37005
7 years, 7 months ago (2013-05-27 07:26:25 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 12:52:30 UTC) #9
Message was sent while issue was closed. 
Change committed as 202399

Powered by Google App Engine
This is Rietveld 408576698