Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/renderer/extensions/dom_activity_logger.cc

Issue 15520002: Moved DOMActionType information from extras into a real field (ActivityLog) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added prefix Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/dom_activity_logger.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/dom_activity_logger.cc
diff --git a/chrome/renderer/extensions/dom_activity_logger.cc b/chrome/renderer/extensions/dom_activity_logger.cc
index 657458473c175b9d7159b6ca1d102e3611301e9d..004195f01e7c8c53db27074071c821d23e6ecd57 100644
--- a/chrome/renderer/extensions/dom_activity_logger.cc
+++ b/chrome/renderer/extensions/dom_activity_logger.cc
@@ -5,6 +5,7 @@
#include "chrome/renderer/extensions/dom_activity_logger.h"
#include "base/logging.h"
+#include "chrome/common/extensions/dom_action_types.h"
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/renderer/chrome_render_process_observer.h"
#include "content/public/renderer/render_thread.h"
@@ -21,13 +22,13 @@ DOMActivityLogger::DOMActivityLogger(const std::string& extension_id,
const GURL& url,
const string16& title)
: extension_id_(extension_id), url_(url), title_(title) {
-}
+} // namespace extensions
void DOMActivityLogger::log(
const WebString& api_name,
int argc,
const v8::Handle<v8::Value> argv[],
- const WebString& extra_info) {
+ const WebString& call_type) {
scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
scoped_ptr<ListValue> argv_list_value(new ListValue());
for (int i =0; i < argc; i++) {
@@ -39,7 +40,13 @@ void DOMActivityLogger::log(
params.url_title = title_;
params.api_call = api_name.utf8();
params.arguments.Swap(argv_list_value.get());
- params.extra = extra_info.utf8();
+ const std::string type = call_type.utf8();
+ if (type == "Getter")
+ params.call_type = DomActionType::GETTER;
+ else if (type == "Setter")
+ params.call_type = DomActionType::SETTER;
+ else
+ params.call_type = DomActionType::METHOD;
content::RenderThread::Get()->Send(
new ExtensionHostMsg_AddDOMActionToActivityLog(extension_id_, params));
« no previous file with comments | « chrome/renderer/extensions/dom_activity_logger.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698