Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6173)

Unified Diff: chrome/browser/about_flags.cc

Issue 1551743002: Add chrome://flags for update menu item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor changes from self review Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e8a93a001204bd271d77aa093a1b8008b21d834a..fa5daa1c927c8eaa3c304e1b4bf0d08ed298ffde 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -488,6 +488,16 @@ const FeatureEntry::Choice kNtpSwitchToExistingTabChoices[] = {
};
#endif // defined(OS_ANDROID)
+#if defined(OS_ANDROID)
+const FeatureEntry::Choice kUpdateMenuItemSummaryChoices[] = {
+ {IDS_FLAGS_UPDATE_MENU_ITEM_NO_SUMMARY, "", ""},
+ {IDS_FLAGS_UPDATE_MENU_ITEM_DEFAULT_SUMMARY,
+ switches::kForceShowUpdateMenuItemSummary, ""},
+ {IDS_FLAGS_UPDATE_MENU_ITEM_CUSTOM_SUMMARY,
+ switches::kForceShowUpdateMenuItemCustomSummary, "Custom summary"},
+};
+#endif // defined(OS_ANDROID)
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name. If you'd like to gather
@@ -2089,6 +2099,30 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_ENABLE_UNIFIED_MEDIA_PIPELINE_DESCRIPTION, kOsAndroid,
SINGLE_VALUE_TYPE(switches::kEnableUnifiedMediaPipeline)},
#endif // OS_ANDROID
+#if defined(OS_ANDROID)
+ {"force-show-update-menu-item",
+ IDS_FLAGS_UPDATE_MENU_ITEM_NAME,
+ IDS_FLAGS_UPDATE_MENU_ITEM_DESCRIPTION,
+ kOsAndroid,
+ SINGLE_VALUE_TYPE(switches::kForceShowUpdateMenuItem)},
+ {"update-menu-item-summary",
+ IDS_FLAGS_UPDATE_MENU_ITEM_SUMMARY_NAME,
+ IDS_FLAGS_UPDATE_MENU_ITEM_SUMMARY_DESCRIPTION,
+ kOsAndroid,
+ MULTI_VALUE_TYPE(kUpdateMenuItemSummaryChoices)},
+ {"force-show-update-menu-badge",
+ IDS_FLAGS_UPDATE_MENU_BADGE_NAME,
+ IDS_FLAGS_UPDATE_MENU_BADGE_DESCRIPTION,
+ kOsAndroid,
+ SINGLE_VALUE_TYPE(switches::kForceShowUpdateMenuBadge)},
+ {"set-market-url-for-testing",
+ IDS_FLAGS_SET_MARKET_URL_FOR_TESTING_NAME,
+ IDS_FLAGS_SET_MARKET_URL_FOR_TESTING_DESCRIPTION,
+ kOsAndroid,
+ SINGLE_VALUE_TYPE_AND_VALUE(
+ switches::kMarketUrlForTesting,
+ "https://market.android.com/details?id=com.android.chrome")},
gone 2015/12/29 01:49:00 I think we should update to Play Store URLs in the
Theresa 2015/12/29 18:16:26 Done.
+#endif // OS_ANDROID
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698