impl/memory: Add "PULL" as valid taskqueue method.

impl/memory/taskqueue_data.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "errors"
         "fmt"
         "net/http"
         "sync"
         "sync/atomic"
 
         "golang.org/x/net/context"
 
         ds "github.com/luci/gae/service/datastore"
         tq "github.com/luci/gae/service/taskqueue"
         "github.com/luci/luci-go/common/clock"
-        "github.com/luci/luci-go/common/stringset"
 )
 
 var (
         currentNamespace = http.CanonicalHeaderKey("X-AppEngine-Current-Namespace")
         defaultNamespace = http.CanonicalHeaderKey("X-AppEngine-Default-Namespace")
 )
 
 //////////////////////////////// taskQueueData /////////////////////////////////
 
 type taskQueueData struct {
@@ skipping 91 matching lines @@
         queueName, err := t.getQueueNameLocked(queueName)
         if err != nil {
                 return err
         }
 
         t.named[queueName] = map[string]*tq.Task{}
         t.archived[queueName] = map[string]*tq.Task{}
         return nil
 }
 
-var tqOkMethods = stringset.NewFromSlice("GET", "POST", "HEAD", "PUT", "DELETE")
-
 func (t *taskQueueData) prepTask(c context.Context, ns string, task *tq.Task, queueName string) (*tq.Task, error) {
         toSched := task.Duplicate()
 
         if toSched.Path == "" {
                 toSched.Path = "/_ah/queue/" + queueName
         }
 
         if toSched.ETA.IsZero() {
                 toSched.ETA = clock.Now(c).Add(toSched.Delay)
         } else if toSched.Delay != 0 {
                 panic("taskqueue: both Delay and ETA are set")
         }
         toSched.Delay = 0
 
-        if toSched.Method == "" {
+        switch toSched.Method {
+        // Methods that can have payloads.
+        case "":
                 toSched.Method = "POST"
-        }
-        if !tqOkMethods.Has(toSched.Method) {
+                fallthrough
+        case "POST", "PUT", "PULL":
+                break
+
+        // Methods that can not have payloads.
+        case "GET", "HEAD", "DELETE":
+                toSched.Payload = nil
+
+        default:
                 return nil, fmt.Errorf("taskqueue: bad method %q", toSched.Method)
         }
-        if toSched.Method != "POST" && toSched.Method != "PUT" {
-                toSched.Payload = nil
-        }
 
         if _, ok := toSched.Header[currentNamespace]; !ok {
                 if ns != "" {
                         if toSched.Header == nil {
                                 toSched.Header = http.Header{}
                         }
                         toSched.Header[currentNamespace] = []string{ns}
                 }
         }
         // TODO(riannucci): implement DefaultNamespace
@@ skipping 81 matching lines @@
         return t.parent.GetTombstonedTasks()
 }
 
 func (t *txnTaskQueueData) GetScheduledTasks() tq.QueueData {
         return t.parent.GetScheduledTasks()
 }
 
 func (t *txnTaskQueueData) CreateQueue(queueName string) {
         t.parent.CreateQueue(queueName)
 }