Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 15502003: Add crash_service to chromium_builder_qa target. (Closed)

Created:
7 years, 7 months ago by Sam Clegg
Modified:
7 years, 7 months ago
Reviewers:
mmoss
CC:
chromium-reviews
Visibility:
Public.

Description

Add crash_service to chromium_builder_qa target. This fixes the NaCl SDK bots which use this target to build chrome and are currently failing to build this binary. BUG=241883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201752

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/all.gyp View 1 2 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
mmoss
https://codereview.chromium.org/15502003/diff/2001/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/15502003/diff/2001/build/all.gyp#newcode401 build/all.gyp:401: ['OS=="win" and target_arch=="ia32"', { target_arch ia32 and crash_service_win64? Sounds ...
7 years, 7 months ago (2013-05-20 23:37:50 UTC) #1
Sam Clegg
https://codereview.chromium.org/15502003/diff/2001/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/15502003/diff/2001/build/all.gyp#newcode401 build/all.gyp:401: ['OS=="win" and target_arch=="ia32"', { On 2013/05/20 23:37:50, mmoss wrote: ...
7 years, 7 months ago (2013-05-20 23:41:19 UTC) #2
mmoss
On 2013/05/20 23:41:19, Sam Clegg wrote: > https://codereview.chromium.org/15502003/diff/2001/build/all.gyp > File build/all.gyp (right): > > https://codereview.chromium.org/15502003/diff/2001/build/all.gyp#newcode401 ...
7 years, 7 months ago (2013-05-20 23:42:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/15502003/2001
7 years, 7 months ago (2013-05-22 17:00:43 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 11:17:25 UTC) #5
Message was sent while issue was closed.
Change committed as 201752

Powered by Google App Engine
This is Rietveld 408576698