Enable seek in fullscreen mode for MSE impl on android

webkit/media/android/webmediaplayer_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/android/webmediaplayer_android.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
@@ skipping 140 matching lines @@
   if (proxy_)
     proxy_->Pause(player_id_);
   is_playing_ = false;
 }
 
 void WebMediaPlayerAndroid::seek(double seconds) {
   pending_seek_ = seconds;
   seeking_ = true;
 
   base::TimeDelta seek_time = ConvertSecondsToTimestamp(seconds);
+#if defined(GOOGLE_TV)

[acolwell GONE FROM CHROMIUM, 2013/05/23 18:21:30]

At a minimum, this code MUST arrange for chunk_demuxer_->CancelPendingSeek() and
chunk_demuxer_->StartWaitingForSeek() inside this call stack like
WebMediaPlayerImpl does. If you don't it can cause playback to deadlock when
there isn't enough data to complete a seek. The call to chunk_demuxer_->Seek()
can be deferred to a later point in time though.

[qinmin, 2013/05/23 20:07:21]

Done. MediaSourceDelegate::Seek() already packs in
chunk_demuxer->StartWaitingForSeek(). Added a call to cancelPendingSeek(). 

On 2013/05/23 18:21:30, acolwell wrote:

+  // TODO(qinmin): check if GTV can also defer the seek until the browser side
+  // player is ready.
   if (media_source_delegate_)
     media_source_delegate_->Seek(seek_time);
+#endif
   if (proxy_)
     proxy_->Seek(player_id_, seek_time);
 }
 
 bool WebMediaPlayerAndroid::supportsFullscreen() const {
   return true;
 }
 
 bool WebMediaPlayerAndroid::supportsSave() const {
   return false;
@@ skipping 319 matching lines @@
 void WebMediaPlayerAndroid::OnMediaPlayerPlay() {
   UpdatePlayingState(true);
   client_->playbackStateChanged();
 }
 
 void WebMediaPlayerAndroid::OnMediaPlayerPause() {
   UpdatePlayingState(false);
   client_->playbackStateChanged();
 }
 
+void WebMediaPlayerAndroid::OnMediaSeekRequest(base::TimeDelta time_to_seek) {
+  if (media_source_delegate_) {
+    media_source_delegate_->Seek(time_to_seek);
+    OnTimeUpdate(time_to_seek);
+  }
+}
+
 void WebMediaPlayerAndroid::UpdateNetworkState(
     WebMediaPlayer::NetworkState state) {
   network_state_ = state;
   client_->networkStateChanged();
 }
 
 void WebMediaPlayerAndroid::UpdateReadyState(
     WebMediaPlayer::ReadyState state) {
   ready_state_ = state;
   client_->readyStateChanged();
@@ skipping 178 matching lines @@
 void WebMediaPlayerAndroid::exitFullscreen() {
   if (proxy_)
     proxy_->ExitFullscreen(player_id_);
 }
 
 bool WebMediaPlayerAndroid::canEnterFullscreen() const {
   return manager_->CanEnterFullscreen(frame_);
 }
 
 }  // namespace webkit_media