Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 15496007: Validate types of arguments passed to V8InjectedScriptHost custom methods. (Closed)

Created:
7 years, 7 months ago by Tom Sepez
Modified:
7 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, adamk+blink_chromium.org, haraken, Nate Chapin
Visibility:
Public.

Description

Validate types of arguments passed to V8InjectedScriptHost custom methods. This adds the typical argument checks to databaseIdMethodCustom() and storageIdMethodCustom(). BUG=242322 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150726

Patch Set 1 #

Patch Set 2 : re-order calls to get "cast" closer to check and avoid needless work on error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Kentaro, please review. Thanks!
7 years, 7 months ago (2013-05-20 23:24:25 UTC) #1
haraken
LGTM
7 years, 7 months ago (2013-05-20 23:28:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15496007/4001
7 years, 7 months ago (2013-05-20 23:44:04 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 00:57:26 UTC) #4
Message was sent while issue was closed.
Change committed as 150726

Powered by Google App Engine
This is Rietveld 408576698