Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 15495003: split file path constants out for split link (Closed)

Created:
7 years, 7 months ago by scottmg
Modified:
7 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

split file path constants out for split link This is a follow on of work started in https://codereview.chromium.org/15310002/ TBR=brettw@chromium.org R=cpu@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201279

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/files/file_path.cc View 6 chunks +5 lines, -16 lines 0 comments Download
A base/files/file_path_constants.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M build/split_link_partition.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years, 7 months ago (2013-05-20 21:22:36 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm achievement unlocked: all trybots are red.
7 years, 7 months ago (2013-05-20 22:10:43 UTC) #2
scottmg
On 2013/05/20 22:10:43, cpu wrote: > lgtm > > achievement unlocked: all trybots are red. ...
7 years, 7 months ago (2013-05-20 22:32:39 UTC) #3
scottmg
7 years, 7 months ago (2013-05-21 00:25:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15495003/7
7 years, 7 months ago (2013-05-21 00:25:51 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 09:44:07 UTC) #6
Message was sent while issue was closed.
Change committed as 201279

Powered by Google App Engine
This is Rietveld 408576698