Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15492007: Make SVG objects ScriptWrappable. (Closed)

Created:
7 years, 7 months ago by Tom Sepez
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, pdr, f(malita), Stephen Chennney, eae+blinkwatch
Visibility:
Public.

Description

Make SVG objects ScriptWrappable. This allows binding integrity checks to be applied to these objects. BUG=236671 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150808

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
M Source/core/svg/SVGElementInstance.h View 5 chunks +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGElementInstanceList.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElementInstanceList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathSeg.h View 2 chunks +9 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegArc.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegClosePath.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubic.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmooth.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadratic.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmooth.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLineto.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontal.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVertical.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegMoveto.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGViewSpec.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyTearOff.h View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Sepez
Adam, please review.
7 years, 7 months ago (2013-05-20 21:06:54 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/15492007/diff/1/Source/core/svg/properties/SVGAnimatedPropertyTearOff.h File Source/core/svg/properties/SVGAnimatedPropertyTearOff.h (right): https://codereview.chromium.org/15492007/diff/1/Source/core/svg/properties/SVGAnimatedPropertyTearOff.h#newcode30 Source/core/svg/properties/SVGAnimatedPropertyTearOff.h:30: class SVGAnimatedPropertyTearOff : public SVGAnimatedProperty, public ScriptWrappable { ...
7 years, 7 months ago (2013-05-20 21:09:05 UTC) #2
Tom Sepez
https://codereview.chromium.org/15492007/diff/1/Source/core/svg/properties/SVGAnimatedPropertyTearOff.h File Source/core/svg/properties/SVGAnimatedPropertyTearOff.h (right): https://codereview.chromium.org/15492007/diff/1/Source/core/svg/properties/SVGAnimatedPropertyTearOff.h#newcode30 Source/core/svg/properties/SVGAnimatedPropertyTearOff.h:30: class SVGAnimatedPropertyTearOff : public SVGAnimatedProperty, public ScriptWrappable { On ...
7 years, 7 months ago (2013-05-20 21:15:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15492007/3002
7 years, 7 months ago (2013-05-20 21:15:17 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=6332
7 years, 7 months ago (2013-05-20 21:46:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15492007/3002
7 years, 7 months ago (2013-05-20 21:48:30 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-20 21:51:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15492007/3002
7 years, 7 months ago (2013-05-21 17:04:34 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 17:32:13 UTC) #9
Message was sent while issue was closed. 
Change committed as 150808

Powered by Google App Engine
This is Rietveld 408576698