Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: tools/telemetry/telemetry/core/chrome/cros_util.py

Issue 15492002: Startup window on chromeos has been disabled. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: indentation Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/chrome/cros_util.py
===================================================================
--- tools/telemetry/telemetry/core/chrome/cros_util.py (revision 202623)
+++ tools/telemetry/telemetry/core/chrome/cros_util.py (working copy)
@@ -84,6 +84,11 @@
'extension passed through --auth-ext-path is valid and belongs '
'to user "chronos".')
- # Wait for the startup window, then close it.
- util.WaitFor(lambda: _StartupWindow(browser_backend) is not None, 20)
- _StartupWindow(browser_backend).Close()
+ if browser_backend.chrome_branch_number < 1500:
+ # Wait for the startup window, then close it. Startup window doesn't exist
+ # post-M27. crrev.com/197900
+ util.WaitFor(lambda: _StartupWindow(browser_backend) is not None, 20)
+ _StartupWindow(browser_backend).Close()
+ else:
+ # Open a new window/tab.
+ browser_backend.tab_list_backend.New(15)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698