Disable intreactive autocomplete and remove command line flag for Android

Disable intreactive autocomplete and remove command line flag for Android

Disabling this feature on beta and stable channels for now. This change will
be reverted on trunk after it is cherrypicked to the branch.

BUG=239478
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201209

[Yusuf, 2013-05-20 20:42:09]

This is the change on trunk that will be cherry-picked to 1500 and then reverted
following up the discussion on https://codereview.chromium.org/15324002/

[Nico, 2013-05-20 21:08:26]

https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome...
File chrome/browser/android/chrome_startup_flags.cc (right):

https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome...
chrome/browser/android/chrome_startup_flags.cc:46:
SetCommandLineSwitch(autofill::switches::kDisableInteractiveAutocomplete);
If a user roots their device and pass an --enable flag, will that flag be in
front of or after this flag?

[Yusuf, 2013-05-20 21:12:43]

After a change last week in chrome_browser_process we started checking 

WebRuntimeFeatures::enableRequestAutocomplete(
      !command_line.HasSwitch(
          autofill::switches::kDisableInteractiveAutocomplete)
so I think EnableInteractiveAutocomplete doesn't do anything right now. I wasn't
able to find anything that check the enable flag currently.



On 2013/05/20 21:08:26, Nico wrote:
>
https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome...
> File chrome/browser/android/chrome_startup_flags.cc (right):
> 
>
https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome...
> chrome/browser/android/chrome_startup_flags.cc:46:
> SetCommandLineSwitch(autofill::switches::kDisableInteractiveAutocomplete);
> If a user roots their device and pass an --enable flag, will that flag be in
> front of or after this flag?

[Nico, 2013-05-20 21:20:51]

Ok, lgtm


On Mon, May 20, 2013 at 2:12 PM, <yusufo@chromium.org> wrote:

> After a change last week in chrome_browser_process we started checking
>
> WebRuntimeFeatures::**enableRequestAutocomplete(
>       !command_line.HasSwitch(
>           autofill::switches::**kDisableInteractiveAutocomplet**e)
> so I think EnableInteractiveAutocomplete doesn't do anything right now. I
> wasn't
> able to find anything that check the enable flag currently.
>
>
>
>
> On 2013/05/20 21:08:26, Nico wrote:
>
> https://codereview.chromium.**org/15491005/diff/1/chrome/**
>
browser/android/chrome_**startup_flags.cc<https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome_startup_flags.cc>
>
>> File chrome/browser/android/chrome_**startup_flags.cc (right):
>>
>
>
> https://codereview.chromium.**org/15491005/diff/1/chrome/**
>
browser/android/chrome_**startup_flags.cc#newcode46<https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome_startup_flags.cc#newcode46>
>
>> chrome/browser/android/chrome_**startup_flags.cc:46:
>> SetCommandLineSwitch(autofill:**:switches::**
>> kDisableInteractiveAutocomplet**e);
>> If a user roots their device and pass an --enable flag, will that flag be
>> in
>> front of or after this flag?
>>
>
>
>
https://codereview.chromium.**org/15491005/<https://codereview.chromium.org/1...
>

[Yusuf, 2013-05-20 21:21:24]

After talking with abodenha@ on this decided to remove ENABLE_AUTOFILL_DIALOG
completely for Android.


On 2013/05/20 21:12:43, Yusuf wrote:
> After a change last week in chrome_browser_process we started checking 
> 
> WebRuntimeFeatures::enableRequestAutocomplete(
>       !command_line.HasSwitch(
>           autofill::switches::kDisableInteractiveAutocomplete)
> so I think EnableInteractiveAutocomplete doesn't do anything right now. I
wasn't
> able to find anything that check the enable flag currently.
> 
> 
> 
> On 2013/05/20 21:08:26, Nico wrote:
> >
>
https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome...
> > File chrome/browser/android/chrome_startup_flags.cc (right):
> > 
> >
>
https://codereview.chromium.org/15491005/diff/1/chrome/browser/android/chrome...
> > chrome/browser/android/chrome_startup_flags.cc:46:
> > SetCommandLineSwitch(autofill::switches::kDisableInteractiveAutocomplete);
> > If a user roots their device and pass an --enable flag, will that flag be in
> > front of or after this flag?

[Albert Bodenhamer, 2013-05-20 21:26:23]

LGTM

https://codereview.chromium.org/15491005/diff/6001/chrome/browser/android/chr...
File chrome/browser/android/chrome_startup_flags.cc (right):

https://codereview.chromium.org/15491005/diff/6001/chrome/browser/android/chr...
chrome/browser/android/chrome_startup_flags.cc:16: #include
"content/public/common/content_switches.h"
nit: Not needed.

[Nico, 2013-05-20 21:29:32]

lgtm as well

https://codereview.chromium.org/15491005/diff/6001/chrome/browser/android/chr...
File chrome/browser/android/chrome_startup_flags.cc (right):

https://codereview.chromium.org/15491005/diff/6001/chrome/browser/android/chr...
chrome/browser/android/chrome_startup_flags.cc:15: #include
"components/autofill/common/autofill_switches.h"
revert this

[commit-bot: I haz the power, 2013-05-20 22:37:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/15491005/10001

[commit-bot: I haz the power, 2013-05-21 03:26:47]

Change committed as 201209